Update NoSQLBench version to leverage the latest 5.21.1#114
Open
msmygit wants to merge 6 commits intodatastax:mainfrom
Open
Update NoSQLBench version to leverage the latest 5.21.1#114msmygit wants to merge 6 commits intodatastax:mainfrom
msmygit wants to merge 6 commits intodatastax:mainfrom
Conversation
joao-r-reis
reviewed
Jun 6, 2024
msmygit
requested review from
absurdfarce,
alicel,
grighetto and
weideng1
as code owners
msmygit
force-pushed
the
main
branch
2 times, most recently
from
15efc87 to
957d8a6
Compare
msmygit
force-pushed
the
main
branch
2 times, most recently
from
323fdd3 to
370b467
Compare
grighetto
reviewed
Jul 18, 2024
| hosts=zdm_tests_origin \ | ||
| localdc=datacenter1 \ | ||
| -v | ||
| #echo "Running NoSQLBench VERIFY job on ORIGIN" |
Collaborator
There was a problem hiding this comment.
Without the VERIFY step, this test is pretty much useless because this is what actually compares the stored data against the pseudo-random generated data.
I don't have the context why the NB update is happening in this PR (if it's for some new feature or compatibility with newer C* versions), but if we could still run the old NB with the verify step in addition to this until it's support in the latest NB version, I think it would be ideal.
Member
Author
There was a problem hiding this comment.
Understood. NB 5.21 doesnt support verify feature yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5.21.xversion.