Add resources templating option to kaap operator deployment#159
Open
MarkusNeuron wants to merge 7 commits intodatastax:mainfrom
Open
Add resources templating option to kaap operator deployment#159MarkusNeuron wants to merge 7 commits intodatastax:mainfrom
MarkusNeuron wants to merge 7 commits intodatastax:mainfrom
Conversation
Author
|
Any update on this one? |
nicoloboschi
approved these changes
Oct 12, 2023
Contributor
|
Thanks @MarkusNeuron |
Contributor
|
@MarkusNeuron can you please fix the CI? I think you have to add the new values property here: |
Add new template variable operator.resources to test
Author
|
Added var to test. Hope this fixes CI. |
Author
|
Test failed again. It seems that the test library can not work with templating functions. I will change test test to an empty resources key. I hope to fix the testcase issue this way. |
Remove requests and changed to empty resource key
Author
|
Sorry guys I do not know how to fix this in test. When I template with: operator:
enabled: true
image: datastax/kaap:0.2.0
imagePullPolicy: IfNotPresent
replicas: 1
resources: {}
livenessProbe:
failureThreshold: 3
...of without resource key at all I get the correct output without resource config. Templating with values: operator:
enabled: true
image: datastax/kaap:0.2.0
imagePullPolicy: IfNotPresent
replicas: 1
resources:
requests:
cpu: "0.2"
memory: "512Mi"
limits:
memory: "512Mi"
livenessProbe:
failureThreshold: 3leads also to the correct template: ...
spec:
containers:
- env:
- name: KUBERNETES_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
envFrom:
- configMapRef:
name: kaap
image: datastax/kaap:0.2.0
imagePullPolicy: IfNotPresent
resources:
limits:
memory: 512Mi
requests:
cpu: "0.2"
memory: 512Mi
livenessProbe:
failureThreshold: 3
...So how we can fix the java for ci testing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For our cluster operation and complying to security standards its mandatory being able to configure pod resources.
Some standards for resources configuration we need to comply:
Because we should be flexible to applying different patterns for resource-requests and -limits I templated the full
resources:block depending on values configuration and not the individual values.E.g. one example pattern for requests and limits