-
Notifications
You must be signed in to change notification settings - Fork 20
CNDB-15995 Add CC 4.0 schema backward compatibility mode #2126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Checklist before you submit for review
|
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java
Outdated
Show resolved
Hide resolved
|
The corresponding CNDB changes are in https://github.com/riptano/cndb/pull/16035 |
|
The StorageCompatibilityModeTest failure looks legit, but otherwise good:
|
Missed that one, thanks. I pushed a commit to fix it. |
|
There is another related test failure in CreateTest - I am investigating that too. |
|
@driftx The test failures related to this PR should be fixed now - the remaining problems reported by butler are those we've been seeing on |
a2339eb to
02cc456
Compare
|
Rebased and resolved conflicts with lastest |
src/java/org/apache/cassandra/cql3/statements/schema/TableAttributes.java
Outdated
Show resolved
Hide resolved
…lass name; Add some more test coverage
…or org.apache.cassandra.db.memtable class names.
|
❌ Build ds-cassandra-pr-gate/PR-2126 rejected by Butler2 regressions found Found 2 new test failures
Found 4 known test failures |



What is the issue
Fixes https://github.com/riptano/cndb/issues/15995
What does this PR fix and why was it fixed
Adds a new
StorageCompatiilityMode.CC4to enable CC 4.0 backward compatibility mode for schema CQL output, allowing CC 5.0 to generate schemas that CC 4.0 can parse without errors.The
StorageCompatiilityMode.CC4value is similar to the existingCASSANDRA_4value except thatCC4permits the use of BTI/TrieIndex format.CNDB tests like CDCMigrationTest involve mixed version writers and CC 5.0 schemas contain options that are unknown to CC 4.0 based writers.
WIth these changes, CNDB 5.0 can set
storage_compatibility_modetoCC4make CC 5.0 filter out 5.0-only table options, allowing a shared schema that CNDB 4.0 nodes are able to process.