Skip to content

[bookie][fix] disable autoshrink to avoid ArrayIndexOutOfBoundsException #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dlg99 wants to merge 1 commit into from
Closed

[bookie][fix] disable autoshrink to avoid ArrayIndexOutOfBoundsException #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public class BookieImpl extends BookieCriticalThread implements Bookie {
private int exitCode = ExitCode.OK;

private final ConcurrentLongHashMap<byte[]> masterKeyCache =
ConcurrentLongHashMap.<byte[]>newBuilder().autoShrink(true).build();
ConcurrentLongHashMap.<byte[]>newBuilder().build();

protected StateManager stateManager;

Expand Down
167 changes: 167 additions & 0 deletions ...erver/src/test/java/org/apache/bookkeeper/util/collections/ConcurrentLongHashMapTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.function.LongFunction;

import org.junit.Ignore;
import org.junit.Test;

/**
Expand Down Expand Up @@ -348,6 +350,7 @@ public void testRehashingWithDeletes() {
assertEquals(map.size(), n);
}


@Test
public void concurrentInsertions() throws Throwable {
ConcurrentLongHashMap<String> map =
Expand Down Expand Up @@ -488,6 +491,170 @@ public void stressConcurrentInsertionsAndReads() throws Throwable {
executor.shutdown();
}

@Ignore("autoShrink=true breaks this test, proper fix tbd")
@Test
public void stressConcurrentInsertionsAndReadsAutoShrink() throws Throwable {
ConcurrentLongHashMap<String> map =
ConcurrentLongHashMap.<String>newBuilder()
.concurrencyLevel(4)
.expectedItems(4)
.autoShrink(true)
.build();
ExecutorService executor = Executors.newCachedThreadPool();

final int writeThreads = 8;
final int readThreads = 8;
final int n = 1_000_000;
String[] values = new String[] {
"v",
"vv",
"vvv",
"vvvv",
"vvvvv",
"vvvvvv",
"vvvvvvv",
"vvvvvvvv",
"vvvvvvvvv",
"vvvvvvvvvv",
};
final int numValues = values.length;

CyclicBarrier barrier = new CyclicBarrier(writeThreads + readThreads);
List<Future<?>> futures = new ArrayList<>();

System.out.println("Starting writes");
for (int i = 0; i < writeThreads; i++) {
final int threadIdx = i;

futures.add(executor.submit(() -> {
Random random = new Random(threadIdx);

try {
barrier.await();
} catch (Exception e) {
throw new RuntimeException(e);
}

for (int j = 0; j < n; j++) {
long key = random.nextLong();
// Ensure keys are uniques
key -= key % (threadIdx + 1);

map.putIfAbsent(key, values[(int)Math.abs(key % numValues)]);
}
}));
}

System.out.println("Starting reads");
for (int i = 0; i < readThreads; i++) {
final int threadIdx = i;

futures.add(executor.submit(() -> {
Random random = new Random(threadIdx);

try {
barrier.await();
} catch (Exception e) {
throw new RuntimeException(e);
}

for (int j = 0; j < n; j++) {
long key = random.nextLong();
// Ensure keys are uniques
key -= key % (threadIdx + 1);

String value = map.get(key);
if (value != null) {
assertEquals(values[(int) Math.abs(key % numValues)], value);
}
}
}));
}

System.out.println("Waiting for futures");
int count = 0;
for (Future<?> future : futures) {
future.get();
count++;
if (count % 1000 == 0) {
System.out.println("Completed " + count + " futures out of " + futures.size());
}
}

assertEquals(map.size(), n * writeThreads);

futures.clear();
barrier.reset();

System.out.println("Starting removes");
for (int i = 0; i < writeThreads; i++) {
final int threadIdx = i;

futures.add(executor.submit(() -> {
Random random = new Random(threadIdx);

try {
barrier.await();
} catch (Exception e) {
throw new RuntimeException(e);
}

for (int j = 0; j < n; j++) {
long key = random.nextLong();
// Ensure keys are uniques
key -= key % (threadIdx + 1);

map.putIfAbsent(key, values[(int)Math.abs(key % numValues)]);
map.remove(key);
String value = map.get(key);
assertNull(value);

}
}));
}

System.out.println("Starting reads 2");
for (int i = 0; i < readThreads; i++) {
final int threadIdx = i;

//for (int k = 0; k < 4; k++) {
futures.add(executor.submit(() -> {
Random random = new Random(threadIdx);

try {
barrier.await();
} catch (Exception e) {
throw new RuntimeException(e);
}

for (int j = 0; j < n; j++) {
long key = random.nextLong();
// Ensure keys are uniques
key -= key % (threadIdx + 1);

String value = map.get(key);
if (value != null) {
assertEquals(values[(int) Math.abs(key % numValues)], value);
}
}
}));
//}
}

System.out.println("Waiting for futures 2");
count = 0;
for (Future<?> future : futures) {
future.get();
count++;
if (count % 1000 == 0) {
System.out.println("Completed " + count + " futures out of " + futures.size());
}
}
futures.clear();

executor.shutdown();
}

@Test
public void testIteration() {
ConcurrentLongHashMap<String> map =
Expand Down