Skip to content

Ignore greeting if some slack group mentioned #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikitasakau wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ignore greeting if some slack group mentioned #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3f6dd4
Corrected regexp in messageHasMentions in order to ignore messages wi…
Oct 2, 2020
ae9d3de
Added test for greeting feature for case when slack group mentioned
Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const messageFromAnyThread = message =>
message.thread_ts !== undefined

const messageHasMentions = (message) => {
const mentionsRegex = /<@(.*?)>/
const mentionsRegex = /<[@!](.*?)>/

return mentionsRegex.test(message.text)
}
Expand Down
10 changes: 10 additions & 0 deletions specs/greetingSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,16 @@ describe('Sample hears controller', () => {
}]).then(message => assert.deepEqual(message, {}))
})

it('does not return any greeting if slack group mentioned', async () => {
await this.controller.usersInput([{
type: 'message',
channel: 'channelId',
messages: [{
text: '<!here>, hey', isAssertion: true,
}],
}]).then(message => assert.deepEqual(message, {}))
})

it('does not return any greeting in threads', async () => {
await this.controller.usersInput([{
type: 'message',
Expand Down