Integrate Trivy #23
Draft
Integrate Trivy #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misofser
commented
Sep 1, 2025
| name = var.project | ||
| region = var.region | ||
| auto_upgrade = true | ||
| surge_upgrade = true |
Author
There was a problem hiding this comment.
This value for surge_upgrade is set by default, But trivy shows warning if it is not defined explicitly.
Misofser
commented
Sep 1, 2025
Comment on lines
+33
to
+39
| resource "aws_s3_bucket_public_access_block" "state" { | ||
| bucket = aws_s3_bucket.state.id | ||
|
|
||
| block_public_acls = true | ||
| block_public_policy = true | ||
| ignore_public_acls = true | ||
| restrict_public_buckets = true |
Author
There was a problem hiding this comment.
Received set of warnings regarding public access block. I think the enabling it here will be useful. Please, let me know if we don't need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds integrating trivy and relates to this issue
Trivy is used, because of now tfsec is part of the trivy