Open
Conversation
chelsealiusa
left a comment
There was a problem hiding this comment.
Is this react-base-app repo only used in custom app, not foundational app?
Will this also help reduce cost for the canary test run if something is wrong with the build?
andriykislitsyn
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have had issues before where an app build should fail (because a package wasn't available) but the build is marked as passing and the app fails to start. This can lead to confusion.
More broadly any script with the format:
will have a successful exit code and lead the app developer to think their build was a success. Commands like:
will mark the build as failed. This is an implementation detail of shell specifically, and not every build-app will use shell. We can easily imagine a build-app with:
So, the smallest change we can do to remind users about this caveat is to just have it in the examples.