Move DBnull scrubbing from C# type to PoweShell#25
Open
jeremymcgee73 wants to merge 2 commits intodataplat:masterfrom
Open
Move DBnull scrubbing from C# type to PoweShell#25jeremymcgee73 wants to merge 2 commits intodataplat:masterfrom
jeremymcgee73 wants to merge 2 commits intodataplat:masterfrom
Conversation
Collaborator
|
Hiyo! I like the idea, particularly for environments that preclude using C# this way. That said, two suggestions!
Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have moved from using a C# type to handle DBNulls to using PowerShell. I used the same logic as the C# function. I mainly did this because C# types do not work in AWS lambda functions. But, I believe it is more readable for PowerShell folks. I believe this also cleaned up the code.