omit config file requirement #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronsteers
commented
Oct 20, 2020
| "REPLICATION_STRATEGY", "INCREMENTAL" | ||
| ) | ||
| config.validate_replication_strategy(replication_strategy) | ||
| catalog_dir = config.get_tap_output_dir(tap_name, taps_dir) |
Collaborator
Author
There was a problem hiding this comment.
Moved these lines up higher so they are able to be used in evaluating the catalog file existance.
| taps_dir=taps_dir, | ||
| config_dir=config_dir, | ||
| config_file=config_file, | ||
| config_file_required=config_file_required, |
Collaborator
Author
There was a problem hiding this comment.
This allows us to say "not required" if we have enough info to run the plan without rerunning the tap.
ahardisty
approved these changes
Oct 21, 2020
ahardisty
left a comment
ahardisty
left a comment
There was a problem hiding this comment.
looks like an elegant solution tucked into a complex system. Well done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update removes the requirement to have the tap installed or to have any config.json file setup - assuming:
Essentially, in those conditions where we just want to update the plan and we already have the cached catalog metadata, we can skip connecting to the remote source and also skip loading the config file.
Note: