feat: Allow setting SEQ_FIRSTRUN_ADMINPASSWORD and SEQ_FIRSTRUN_ADMINPASSWORDHASH from Secret

[mloskot]

If firstRunAdminPasswordSecret or firstRunAdminPasswordHashSecret object is defined with name of existing Kubernetes secret and its data key, hen envFrom is used to define the container environment variable with password or password hash value retrieved from the given secret key.

Closes #64

Warning

I'm Helm templates rookie, I'm not sure how to test it without releasing a new chart. There seem to be no test cases defined.

Examples

Here are values.yaml samples:

firstRunAdminPasswordSecret:
  name: my-seq-password
  key: password

Or, after update discussed in sub-thread that began in #65 (comment),

firstRunAdminPasswordHashSecret:
  name: my-seq-password-hash
  key: password

[KodrAus]

Thanks for working on this @mloskot! I haven't figure out decent CI for Helm yet so I tend to test changes to the chart locally with helm install, which can accept a local filepath to a chart.

I think we'll just need to update this if block: https://github.com/datalust/helm.datalust.co/blob/main/charts/seq/templates/deployment.yaml#L183 to also accept a value in .Values.firstRunAdminPasswordSecret.

[mloskot]

@KodrAus Pleasure. It's also an opportunity to finally learn some Helm charts development :)

I haven't figure out decent CI for Helm yet so I tend to test changes to the chart locally with helm install, which can accept a local filepath to a chart.

Yes, as I displayed in the resolved comment #65 (comment), I've learned these three tools:

helm lint
helm template --debug ...
helm install --dry-run --debug ...

I've also learned Helm v3 introduced schemas for values, so perhaps it is a good idea to stick values.schema.json next to values.yaml or is it an overkill? What do you think?

I think we'll just need to update this if block: https://github.com/datalust/helm.datalust.co/blob/main/charts/seq/templates/deployment.yaml#L183 to also accept a value in .Values.firstRunAdminPasswordSecret.

Good point. Done.

[mloskot]

@KodrAus What do you think about setting SEQ_FIRSTRUN_ADMINPASSWORDHASH / firstRunAdminPasswordHash from a secret passed via firstRunAdminPasswordHashSecret ?

[KodrAus]

@mloskot I don't see any harm in supporting it 👍 If you're feeling keen to roll that in to this PR we can take a look, otherwise I'm happy to merge this and leave that for the future. Since the password hash is already safe to leave in cleartext it's less of an issue I think.

[KodrAus]

Thanks @mloskot! This looks good to me.

[mloskot]

@KodrAus I think it makes sense to complete this PR. So, I've updated this PR with the implementation of firstRunAdminPasswordHashSecret. Having values.yaml with required values set, all the helm lint and helm template --debug commands succeeded for me.

[KodrAus]

Thanks for working through all this @mloskot. This looks good to me 👍