Add flag to disable DruidIngestion controller#254
Merged
AdheipSingh merged 1 commit intodatainfrahq:masterfrom Feb 5, 2026
Merged
Conversation
Add --disable-ingestion-controller flag to allow running the operator without the DruidIngestion CRD installed. This is useful for users who only need the Druid CR functionality. Changes: - main.go: Add flag and conditional controller setup - chart/values.yaml: Add disableIngestionController option - chart/templates/deployment.yaml: Pass flag when enabled
Contributor
Author
|
@AdheipSingh could you please review it . And let me know if anything else is required ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #187
Description
The operator fails to start if the DruidIngestion CRD is not installed, even when users only need the Druid CR functionality. This PR adds a
--disable-ingestion-controllerflag that allows the operator to run without requiring the DruidIngestion CRD.Key changed/added files in this PR
main.go- Added--disable-ingestion-controllerflag and conditional controller setupchart/values.yaml- AddeddisableIngestionController: falseoptionchart/templates/deployment.yaml- Pass flag to operator when enabledThis PR has:
helm lint ./chart- passeshelm template- renders correctly with default values (flag not present)helm template --set disableIngestionController=true- renders correctly with flag presentUsage
Via Helm: