fix: read router port from service spec instead of hardcoded value#253
Open
piyush302 wants to merge 1 commit intodatainfrahq:masterfrom
Open
fix: read router port from service spec instead of hardcoded value#253piyush302 wants to merge 1 commit intodatainfrahq:masterfrom
piyush302 wants to merge 1 commit intodatainfrahq:masterfrom
Conversation
- Modified GetRouterSvcUrl to read port from discovered service - Fallback to default DruidRouterPort (8088) if no ports defined - Fixes issue where custom port configurations broke DruidIngestion Fixes datainfrahq#220
Contributor
Author
|
@AdheipSingh could you please review it . And let me know if anything else is required ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220
Description
The router port was hardcoded to
8088inGetRouterSvcUrl(), which broke DruidIngestion for users who configured custom ports in their Druid CR.This PR modifies the function to read the actual port from the discovered Kubernetes Service spec, with a fallback to the default port (8088) for backward compatibility.
Key changed/added files in this PR
pkg/druidapi/druidapi.goTesting
http://druid-tiny-cluster-routers.druid:8088/...✅http://druid-tiny-cluster-routers.druid:9999/...✅