feat: add support for HTTPS and port interpolation on Druid ingestions#234
Open
Rasnar wants to merge 1 commit intodatainfrahq:masterfrom
Open
feat: add support for HTTPS and port interpolation on Druid ingestions#234Rasnar wants to merge 1 commit intodatainfrahq:masterfrom
Rasnar wants to merge 1 commit intodatainfrahq:masterfrom
Conversation
Author
|
I'm mostly interested in gathering some feedback on this, because currently this information is only specified in the runtimes configs (plain text/tls protocol+port). If we don't want to parse this config, then we could instead read the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces support for HTTPS in the Druid ingestion part of the operator. Previously, the port and protocol used were not configurable, limiting its flexibility. This update enables extrapolating these parameters from cluster-level ConfigMaps.
Key changes made in the patch:
GetRouterSvcUrlfor improved context management.This PR has:
Key changed/added files in this PR
controllers/druid/dynamic_config.gocontrollers/ingestion/reconciler.gopkg/druidapi/druidapi.gopkg/druidapi/druidapi_test.go