Update Node to v24, drop yarn support, switch to vanilla NPM #2073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikholopov-omni
force-pushed
the
noyarn
branch
3 times, most recently
from
0ed3699 to
83c5894
Compare
ikholopov-omni
changed the title
ikholopov-omni
force-pushed
the
noyarn
branch
2 times, most recently
from
5d86281 to
d3005f5
Compare
ikholopov-omni
force-pushed
the
noyarn
branch
from
d3005f5 to
30f5b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Update Node version that bazel uses for building and testing target to a modern LTS version.
This shouldn't affect the compatibility of @dataform/core or @dataform/cli packages with node version of the end-users, we don't change any compiler or dependencies with this change.
The only failing test is the one that catches a message from the node system library for JSON parsing, updating it.
2. Drop yarn & use only NPM.
Current NPM/yarn integration doesn't work well with trusted repositories - we force to use NPM install with bazel-rule handled fallback of converting lock files. This fallback doesn't work with a more version of Node version, corrupting yarn lock file. Replacing it with package-lock.json instead.
As we will migrate to