Skip to content

Conversation

@mkllnk
Copy link
Collaborator

@mkllnk mkllnk commented Dec 17, 2025

With the imminent release of the DFC version 2.0, we need to clearly communicate which context we are using here. This Connector library is still on version 1.16 and the upgrade path is not defined yet.

@mkllnk mkllnk self-assigned this Dec 17, 2025
@mkllnk mkllnk marked this pull request as ready for review December 17, 2025 02:52
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but it's a bit unclear why we need both URL and URL_NORMALISED ?

class Context < JSON::LD::Context
URL = "https://www.datafoodconsortium.org"
URL_NORMALISED = "http://www.datafoodconsortium.org/"
URL = "https://w3id.org/dfc/ontology/context/context_1.16.0.json"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have both URL and URL_NORMALISED ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought a lot about this and I'm not sure. Garethe gave me the https version. And I think it's safer to use https. But a lot of the semantic web seems to just use http to identify something. For example, we now use an official vocabulary to identify countries. You can visit https://publications.europa.eu/resource/authority/country/TCD and it identifies as http://publications.europa.eu/resource/authority/country/TCD. Most software follows links blindly without trying to convert http to https. That opens us up to man-in-the-middle attacks.

I think that defining two URLs is safer and compatible. But happy to just use one if you convince me that it's safe.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would favour https as well, so it make sense to keep it.

Copy link
Collaborator

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@mkllnk mkllnk merged commit 5c372e8 into datafoodconsortium:main Dec 17, 2025
4 checks passed
@mkllnk mkllnk deleted the context branch December 17, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants