-
Notifications
You must be signed in to change notification settings - Fork 1
Lock context to version 1.16 to prevent upgrade to 2.0 #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rioug
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but it's a bit unclear why we need both URL and URL_NORMALISED ?
| class Context < JSON::LD::Context | ||
| URL = "https://www.datafoodconsortium.org" | ||
| URL_NORMALISED = "http://www.datafoodconsortium.org/" | ||
| URL = "https://w3id.org/dfc/ontology/context/context_1.16.0.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to have both URL and URL_NORMALISED ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought a lot about this and I'm not sure. Garethe gave me the https version. And I think it's safer to use https. But a lot of the semantic web seems to just use http to identify something. For example, we now use an official vocabulary to identify countries. You can visit https://publications.europa.eu/resource/authority/country/TCD and it identifies as http://publications.europa.eu/resource/authority/country/TCD. Most software follows links blindly without trying to convert http to https. That opens us up to man-in-the-middle attacks.
I think that defining two URLs is safer and compatible. But happy to just use one if you convince me that it's safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would favour https as well, so it make sense to keep it.
dacook
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
With the imminent release of the DFC version 2.0, we need to clearly communicate which context we are using here. This Connector library is still on version 1.16 and the upgrade path is not defined yet.