Skip to content

Conversation

@n-h-diaz
Copy link
Contributor

@n-h-diaz n-h-diaz commented Jan 27, 2026

The endpoint was deprecated in Apigee in https://github.com/datacommonsorg/mixer/pull/1711/files and has no references or requests

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @n-h-diaz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on removing all traces of the /v1/bulk/observation-existence endpoint, which was previously marked as deprecated. The changes encompass the removal of its protobuf definition, gRPC service interfaces and implementations, server-side handler, and related test files. This systematic deletion streamlines the codebase by eliminating unused components, enhancing maintainability, and reducing the overall project footprint.

Highlights

  • Endpoint Removal: The /v1/bulk/observation-existence endpoint and all associated code have been completely removed from the codebase.
  • Code Cleanup: This pull request performs a significant cleanup by deleting obsolete protobuf definitions, gRPC service implementations, and server-side handler logic for a previously deprecated endpoint.
  • Test Artifacts Removed: Corresponding golden test data and test files for the removed endpoint have also been deleted, ensuring no lingering test cruft.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@n-h-diaz n-h-diaz marked this pull request as ready for review January 27, 2026 02:25
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully removes all traces of the deprecated /v1/bulk/observation-existence endpoint. This includes the RPC definition in mixer.proto, its corresponding generated Go code in mixer.pb.go and mixer_grpc.pb.go, the handler implementation in handler_v1.go, and the related golden test files. The changes are clean and align with the objective of deleting obsolete code.

@n-h-diaz n-h-diaz requested a review from keyurva January 27, 2026 17:39
@n-h-diaz n-h-diaz added this pull request to the merge queue Jan 27, 2026
Merged via the queue into datacommonsorg:master with commit 8facbf8 Jan 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants