-
Notifications
You must be signed in to change notification settings - Fork 130
PR to bring configs for MOSPI_IndiaPLFS_MonthlyWages and MOSPI_IndiaPLFS_DailyWages #1851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @saanikaaa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates new wage data from the Ministry of Statistics and Programme Implementation (MOSPI) in India, specifically from the Periodic Labour Force Survey (PLFS). It provides the necessary configuration files to support both daily and monthly wage statistics, allowing the system to ingest and represent this data across various Indian regions and demographic categories. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds configuration files for MOSPI_IndiaPLFS_MonthlyWages and MOSPI_IndiaPLFS_DailyWages. The changes are mostly good, but I've found a data correctness issue with a wikidataId and a few files are missing a final newline character. I've left specific comments with suggestions.
| Bihar,wikidataId/Q1165 | ||
| Chandigarh,wikidataId/Q120971341 | ||
| Chhattisgarh,wikidataId/Q1168 | ||
| Dadra & Nagar Haveli,wikidataId/Q77997266 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Bihar,wikidataId/Q1165 | ||
| Chandigarh,wikidataId/Q120971341 | ||
| Chhattisgarh,wikidataId/Q1168 | ||
| Dadra & Nagar Haveli,wikidataId/Q77997266 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -0,0 +1,2 @@ | |||
| parameter,value | |||
| header_rows,1 No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Uttar Pradesh,wikidataId/Q1498 | ||
| West Bengal,wikidataId/Q1356 | ||
| Ladakh,wikidataId/Q200667 | ||
| Dadra & Nagar Haveli & Daman & Diu,wikidataId/Q77997266 No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| JAN-MAR,Month,2,observationPeriod,P3M,,,, | ||
| value,observationDate,{Year}-{Month},value,{Number},,,, | ||
| unit,unit,INR,,,,,, | ||
| state,observationAbout,{Data},,,,,, No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Uttar Pradesh,wikidataId/Q1498 | ||
| West Bengal,wikidataId/Q1356 | ||
| Ladakh,wikidataId/Q200667 | ||
| Dadra & Nagar Haveli & Daman & Diu,wikidataId/Q77997266 No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| JAN-MAR,Month,2,observationPeriod,P3M,, | ||
| value,observationDate,{Year}-{Month},value,{Number},, | ||
| unit,unit,INR,,,, | ||
| state,observationAbout,{Data},,,, No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.