Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 87 additions & 0 deletions tests/test_artifacts_policy.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,3 +216,90 @@ def test_run_mart_supports_root_posix_placeholder(tmp_path: Path) -> None:
assert mart_output.exists()
assert duckdb.execute(f"SELECT marker FROM read_parquet('{mart_output.as_posix()}')").fetchone() == ("ok",)
assert result["output_rows"] == 1


def test_run_mart_supports_support_placeholder(tmp_path: Path) -> None:
config_path = tmp_path / "dataset.yml"
sql_dir = tmp_path / "sql"
sql_dir.mkdir(parents=True, exist_ok=True)
root_dir = tmp_path / "out"
dataset = "demo_ds"
year = 2022

clean_dir = root_dir / "data" / "clean" / dataset / str(year)
clean_dir.mkdir(parents=True, exist_ok=True)
clean_path = clean_dir / f"{dataset}_{year}_clean.parquet"
duckdb.execute(f"COPY (SELECT 1 AS value) TO '{clean_path.as_posix()}' (FORMAT PARQUET)")

support_root = tmp_path / "support_out"
support_output = support_root / "data" / "mart" / "lookup_ds" / "2024" / "lookup_table.parquet"
support_output.parent.mkdir(parents=True, exist_ok=True)
duckdb.execute(
f"COPY (SELECT 'ok' AS marker) TO '{support_output.as_posix()}' (FORMAT PARQUET)"
)

support_config = tmp_path / "support_dataset.yml"
support_config.write_text(
"\n".join(
[
f'root: "{support_root.as_posix()}"',
"dataset:",
' name: "lookup_ds"',
" years: [2024]",
"raw: {}",
"clean: {}",
"mart:",
" tables:",
' - name: "lookup_table"',
' sql: "sql/lookup.sql"',
]
),
encoding="utf-8",
)

(sql_dir / "mart_example.sql").write_text(
"select * from read_parquet('{support.lookup.mart}')",
encoding="utf-8",
)
config_path.write_text(
"\n".join(
[
f'root: "{root_dir.as_posix()}"',
"dataset:",
f' name: "{dataset}"',
f" years: [{year}]",
"raw: {}",
"clean:",
' sql: "sql/clean.sql"',
"mart:",
" tables:",
' - name: "mart_example"',
' sql: "sql/mart_example.sql"',
"support:",
' - name: "lookup"',
f' config: "{support_config.as_posix()}"',
" years: [2024]",
]
),
encoding="utf-8",
)
(tmp_path / "sql" / "clean.sql").write_text("select 1 as value", encoding="utf-8")

cfg = load_config(config_path)
logger = _NoopLogger()
result = run_mart(
cfg.dataset,
year,
cfg.root,
cfg.mart,
logger,
base_dir=cfg.base_dir,
clean_cfg=cfg.clean,
output_cfg=cfg.output,
support_cfg=cfg.support,
)

mart_output = root_dir / "data" / "mart" / dataset / str(year) / "mart_example.parquet"
assert mart_output.exists()
assert duckdb.execute(f"SELECT marker FROM read_parquet('{mart_output.as_posix()}')").fetchone() == ("ok",)
assert result["output_rows"] == 1
62 changes: 62 additions & 0 deletions tests/test_cli_inspect_paths.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,65 @@ def test_inspect_paths_json_is_notebook_friendly(tmp_path: Path, monkeypatch) ->
assert payload["raw_hints"]["suggested_read_exists"] is False
assert payload["raw_hints"]["suggested_read_path"].endswith("suggested_read.yml")
assert payload["latest_run"] is None


def test_inspect_paths_json_reports_resolved_support_outputs(tmp_path: Path) -> None:
runner = CliRunner()

support_root = tmp_path / "support_out"
support_config = tmp_path / "support_dataset.yml"
support_config.write_text(
"\n".join(
[
f'root: "{support_root.as_posix()}"',
"dataset:",
' name: "support_ds"',
" years: [2024]",
"raw: {}",
"clean: {}",
"mart:",
" tables:",
' - name: "support_table"',
' sql: "sql/support.sql"',
]
),
encoding="utf-8",
)

config_path = tmp_path / "dataset.yml"
root_dir = tmp_path / "out"
config_path.write_text(
"\n".join(
[
f'root: "{root_dir.as_posix()}"',
"dataset:",
' name: "demo_ds"',
" years: [2022]",
"raw: {}",
"clean: {}",
"mart: {}",
"support:",
' - name: "scuole"',
f' config: "{support_config.as_posix()}"',
" years: [2024]",
]
),
encoding="utf-8",
)

result = runner.invoke(
app,
["inspect", "paths", "--config", str(config_path), "--year", "2022", "--json", "--strict-config"],
)

assert result.exit_code == 0, result.output
payload = json.loads(result.output)
assert payload["paths"]["support"]
support_payload = payload["paths"]["support"][0]
assert support_payload["name"] == "scuole"
assert support_payload["dataset"] == "support_ds"
assert support_payload["years"] == [2024]
assert support_payload["outputs"] == [
str(support_root / "data" / "mart" / "support_ds" / "2024" / "support_table.parquet")
]
assert support_payload["mart"].endswith("support_table.parquet")
63 changes: 63 additions & 0 deletions tests/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,69 @@ def test_load_config_resolves_relative_paths_from_dataset_dir(tmp_path: Path):
assert cfg.cross_year["tables"][0]["sql"] == (project_dir / "sql" / "cross" / "demo_cross.sql").resolve()


def test_load_config_resolves_support_config_paths_from_dataset_dir(tmp_path: Path):
project_dir = tmp_path / "project"
support_dir = tmp_path / "support"
project_dir.mkdir()
support_dir.mkdir()

yml = project_dir / "dataset.yml"
yml.write_text(
"""
root: "./out"
dataset:
name: demo
years: [2022]
raw: {}
clean: {}
mart: {}
support:
- name: scuole
config: "../support/dataset.yml"
years: [2024]
""".strip(),
encoding="utf-8",
)

cfg = load_config(yml)

assert cfg.support == [
{
"name": "scuole",
"config": (support_dir / "dataset.yml").resolve(),
"years": [2024],
}
]


def test_load_config_rejects_duplicate_support_names(tmp_path: Path):
yml = tmp_path / "dataset.yml"
yml.write_text(
"""
root: "./out"
dataset:
name: demo
years: [2022]
raw: {}
clean: {}
mart: {}
support:
- name: scuole
config: "./support_a.yml"
years: [2024]
- name: scuole
config: "./support_b.yml"
years: [2025]
""".strip(),
encoding="utf-8",
)

with pytest.raises(ValueError) as e:
load_config(yml)

assert "support[].name values must be unique" in str(e.value)


def test_load_config_does_not_transform_non_whitelisted_path_like_fields(tmp_path: Path):
project_dir = tmp_path / "project"
project_dir.mkdir()
Expand Down
Loading
Loading