Conversation
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a402c10a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosa fa
Aggiunge il source type
sdmxper acquisire dati ISTAT (e altri provider SDMX) direttamente in CSV normalizzato.Perimetro v1
versionobbligatoria e strict: il plugin verifica che la versione richiesta corrisponda a quella esposta dal dataflow live; nessun fallback silenzioso alatestfilterssu dimensioni di serie (non TIME_PERIOD)DIM,DIM_label,valueagencyopzionale, defaultIT1Componenti
toolkit/plugins/sdmx.py—SdmxSourceconfetch(agency, flow, version, filters)toolkit/core/registry.py— entrysdmxnei built-in plugintoolkit/raw/run.py— integrazione_fetch_payloade_infer_ext(.csvfisso per sdmx)tests/test_sdmx_plugin.py— CSV normalizzato, version mismatch, filter dimension sconosciutadocs/config-schema.md— esempio e note pratiche persdmxsmoke/istat_sdmx_22_289/— smoke reale su22_289(popolazione residente ISTAT)Verifiche
raw,clean,martsu22_289: okCaveat noto
WinError 5surun allsu Windows è preesistente e non specifico di questo branch.Note
Il retry loop usa
range(max(1, self.retries)): conretries=2fa 2 tentativi, coerente conCkanSource. Da tenere a mente per chi si aspettaretries+1tentativi.Nota
Questo connettore e' complementare a ondata/istat_mcp_server di @aborruso: il suo MCP serve all'esplorazione interattiva dei dataflow ISTAT, questo plugin serve all'ingestion automatica in pipeline. I due layer si parlano bene - chi usa il suo MCP per trovare il dataflow giusto e i filtri corretti puo' poi usare questo connettore per scaricare i dati in modo riproducibile.
Closes #71
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com