Ridurre il surface area del toolkit e consolidare il contract runtime#3
Merged
Ridurre il surface area del toolkit e consolidare il contract runtime#3
Conversation
# Conflicts: # toolkit/profile/raw.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧾 Pull Request – DataCivicLab
🔗 Issue collegata
Closes #4
🎯 Contesto
Questa PR consolida il lavoro finale di hardening, riduzione del surface area e riallineamento del
toolkital ruolo corretto nell’ecosistema DataCivicLab.Nel modello attuale:
.githubcontiene policy condivise, community health e template GitHubdataciviclabè l’hub pubblico/minimale dell’organizzazioneproject-templateè il template operativo dei repo datasettoolkitdeve restare il motore tecnico della pipeline e la fonte dei contract runtime/config/path/outputLa PR porta il toolkit a una forma più piccola, più leggibile e più coerente con il workflow reale dei repo dataset:
run allvalidate allstatusinspect paths⚙️ Cosa cambia
coregen-sqlclean.duckdb_readclean.input_selectionclean.runclean.validateprofile.rawmetadata.json,manifest.json, run records einspect pathscore,advanced,compat) e documenta meglio la suiteproject-templatee col workflow canonico📊 Impatto su dati / metodo / dashboard
Indicare se questa PR impatta:
Effetti su replicabilità e confrontabilità:
🧪 QA Checklist
Verifiche eseguite:
py -3.14 -m pytest -q -p no:cacheprovider146 passedpy -3.14 -m ruff check --no-cache .📝 Note per i reviewer
Punti da guardare con attenzione:
inspect pathse il contractmetadata / manifest / run recordssono il punto chiave per notebook e repo datasetcleaneprofile.rawsono stati contenuti senza cambiare il contratto pubblico: il focus della review dovrebbe essere sulla chiarezza e sulla preservazione del comportamento