fix: rispetta mode all ed explicit nel clean#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obiettivo
Closes #20
Correggere la selezione degli input RAW nel layer
cleanquando il dataset usa casi multi-source.In alcuni casi, la presenza di
primary_output_filenel manifest RAW finiva per scavalcare il comportamento richiesto da:clean.read.mode: allclean.read.mode: explicitProblema
Il risultato era che il
cleanpoteva leggere un solo file RAW anche quando il config chiedeva esplicitamente:all)include/exclude(explicit)Questo comportamento è emerso su un caso reale nel filone SIOPE in fase di test, ma il bug è generale e non dipende dal dataset.
Cosa cambia
Il fix mantiene il comportamento standard nel caso semplice, ma evita che
primary_output_filescavalchi:mode: allmode: explicitIn pratica:
latestcontinua a usare la logica standardlargestcontinua a usare la logica standardalllegge tutti i file selezionatiexplicitrispettainclude/excludeFile toccati
toolkit/clean/input_selection.pytests/test_clean_input_selection.pyTest
Eseguiti: