fix: preserve year templates in local raw paths#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sintesi
Closes #17
Questa PR corregge un bug nel caricamento config: i path RAW
local_filecon{year}venivano normalizzati troppo presto e il placeholder non arrivava fino arun raw.Problema
Prima del fix:
raw.sources[].args.pathcon{year}veniva convertito inPath_format_args()inrun_raw()applicava la sostituzione solo alle stringhelocal_filefalliva su path tipodemo_{year}.csvCosa cambia
Durante la normalizzazione config:
{year}restano stringhedataset.yml{year}resta disponibile fino al runScope
Dentro il perimetro:
raw.sources[].args.pathFuori scope:
{year}Test
Eseguiti:
Esito:
54 passedVerifica reale
Usato su due dataset multi-anno locali:
RU Comunali 2018-2024run rawcorretto su tutti gli anniinspect schema-diffmostra schema stabileIRPEF comunale 2018-2023run rawcorretto su tutti gli anniinspect schema-diffrileva drift reale:2020 -> 2021Bonus spettante->Trattamento spettante2022 -> 2023Reddito complessivo - FrequenzaReddito complessivo - Ammontare in euroNota
Il fix trova il suo posto nel workflow per dataset storici e multi-anno:
dataset.yml -> run raw -> inspect schema-diff -> clean