Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9
Summary
Questa PR introduce un primo supporto
.xlsxnel layer CLEAN.La pipeline resta coerente:
Scope
Supporto iniziale limitato e intenzionale:
.xlsx.xlsclean.read.sheet_nameheader,skip,columns,trim_whitespaceScelte implementative
openpyxlcome dipendenza runtime.xlsxpandas.read_excel(..., engine=\"openpyxl\")sheet_namenon e' specificatoclean.read.columnse' presentePerche'
Il caso reale
terna-domanda-22.xlsxmostrava bene il limite attuale:Con questa PR, il workbook puo' restare nel suo formato originale e il runtime gestisce la lettura nel punto giusto della pipeline.
Testing
Eseguito:
Esito:
28 passed152 passedSmoke reale eseguito con:
terna-domanda-22.xlsxEsito:
run all:SUCCESSvalidate all:SUCCESSstatus:SUCCESSStress test reali aggiuntivi nel laboratorio locale:
case_11_civile_flussi_2014_2024Read me+ fogliodataclean.read.sheet_namecase_12_consumi_gas_2023_2024_zona_climaticaEsito anche per questi due casi:
run all:SUCCESSvalidate all:SUCCESSstatus:SUCCESSinspect paths:SUCCESSNote
.xlsx.xls, multi-sheet piu' avanzato, profiling Excel) restano fuori da questo scope