Skip to content

Conversation

@kaysiz
Copy link
Member

@kaysiz kaysiz commented Nov 11, 2025

Purpose

https://github.com/datacite/product-backlog/issues/506

  • Security & Maintenance: Rails 7.1 approaching end-of-life, Rails 7.2 provides latest security patches and bug fixes
  • Performance Goals: Ruby 3.2.9 offers significant performance improvements (MJIT enhancements, better GC)
  • Dependency Compatibility: Many gems require newer Rails versions for optimal compatibility

Approach

Incremental Migration Strategy

  • Configuration Updates: Updated config.load_defaults from 7.1 to 7.2
  • Compatibility Fixes: Addressed breaking changes one subsystem at a time:
    • JWT authentication system
    • Database testing infrastructure
    • GraphQL type system
    • Elasticsearch integration
    • Audit trail functionality

Testing & Validation

  • Test-Driven Fixes: Fixed failing tests to understand exact compatibility issues
  • Regression Prevention: Ensured each fix didn't break other functionality

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@kaysiz kaysiz self-assigned this Nov 11, 2025
@jrhoads jrhoads added the run-all-tests Run All CI Tests label Nov 11, 2025
@kaysiz kaysiz changed the title Rails upgrade - 7.2.3 Rails 7.1 → 7.2 & Ruby 3.1.7 → 3.2.9 Upgrade Jan 5, 2026
@kaysiz kaysiz changed the title Rails 7.1 → 7.2 & Ruby 3.1.7 → 3.2.9 Upgrade Upgrade: Rails 7.1 → 7.2 & Ruby 3.1.7 → 3.2.9 Jan 5, 2026
@kaysiz kaysiz marked this pull request as ready for review January 5, 2026 08:47
@kaysiz kaysiz requested a review from a team January 5, 2026 08:47
@jrhoads
Copy link
Contributor

jrhoads commented Jan 5, 2026

@kaysiz Overall fantastic work.

We should test this with ruby 3.2
I see you updated the Dockerfile, but we should also update the version of Ruby used in the github action. Currently it is testing with version 3.1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-all-tests Run All CI Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants