Skip to content

Conversation

@jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Dec 16, 2025

Purpose

This PR updates the vega-lite dependency to a newer version. This update includes several changes to the underlying dependencies that vega-lite relies on, such as vega-expression, vega-util, and yargs.

Approach

The primary change is updating the vega-lite package to a version within the ^6.1 range. This has resulted in corresponding updates to several other packages, including vega-expression, vega-util, and yargs, to ensure compatibility.

Key Modifications

  • Updated vega-lite from ^5.19.0 to ^6.1.
  • Updated vega-expression from ~5.1.1 to ^6.1.0.
  • Updated vega-util from ^1.17.2 to ^2.1.0.
  • Updated yargs from ^17.7.2 to ^18.0.0.
  • Updated vega-event-selector from ~3.0.1 to ~4.0.0.

Important Technical Details

The dependency updates have brought in newer versions of packages related to terminal output formatting and command-line argument parsing (e.g., cliui, string-width, strip-ansi, wrap-ansi, yargs-parser). These updates are generally improvements and should not introduce breaking changes to the application's core functionality.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

  • Dependency Upgrade

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Summary by CodeRabbit

  • Chores
    • Updated vega-lite visualization library dependency from version 5.19.0 to 6.1. The new version includes recent enhancements, performance optimizations, and bug fixes to support improved charting and visualization capabilities.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

Walkthrough

Dependency version bump for vega-lite from ^5.19.0 to ^6.1 in package.json. No functional code changes or logic modifications.

Changes

Cohort / File(s) Change Summary
Dependency Version Update
package.json
Updated vega-lite dependency version from ^5.19.0 to ^6.1

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single dependency version update with no code logic changes or functional impact

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Bump vega-lite dependency' directly and specifically describes the primary change—upgrading the vega-lite package version from ^5.19.0 to ^6.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upgrade-vega-lite

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5250c2a and c0abd7f.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: test / cypress (4)
  • GitHub Check: test / cypress (1)
  • GitHub Check: test / cypress (3)
  • GitHub Check: test / cypress (5)
  • GitHub Check: test / cypress (2)

"vega": "^6.2.0",
"vega-embed": "^6.25.0",
"vega-lite": "^5.19.0",
"vega-lite": "^6.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Verify react-vega compatibility and breaking changes before merging vega-lite 6.x.

This is a major version upgrade (5.x → 6.x) with breaking changes. Key concerns:

  1. react-vega 7.6.0 supports both vega and vega-lite, but there is no explicit documentation confirming it was tested with vega-lite 6.x. Altair 6.0.0 required a major version bump to support vega-lite 6.1.0, suggesting other libraries may need updates for compatibility.

  2. Breaking changes have been identified in vega-lite 6.x. Verify that any vega-lite specifications in the codebase are compatible with the new version (schema changes, deprecated APIs, etc.).

  3. Test the application thoroughly after the upgrade to ensure all vega-lite visualizations render correctly and functionality is preserved.

🤖 Prompt for AI Agents
In package.json around line 81, the dependency bump to "vega-lite": "^6.1" is a
major upgrade with breaking changes and potential incompatibility with
react-vega; verify compatibility by (1) checking react-vega release notes and
code for explicit support of vega-lite 6.x or plan to upgrade react-vega if a
newer compatible release exists, (2) searching the repo for all vega-lite specs
and updating any schema/deprecated fields to the 6.x schema, (3) running
unit/integration/visual tests and manually validating key visualizations in the
app, and (4) if immediate compatibility isn’t confirmed, revert or pin vega-lite
to the last known-good 5.x version and add tests or CI visual snapshots before
re-attempting the major upgrade.

@cypress
Copy link

cypress bot commented Dec 16, 2025

akita    Run #1817

Run Properties:  status check passed Passed #1817  •  git commit 27cf727608 ℹ️: Merge c0abd7f161fa0f85b9ef981a7c5e972af700e1c7 into 5250c2ad365622db1b7c1f2c26d0...
Project akita
Branch Review upgrade-vega-lite
Run status status check passed Passed #1817
Run duration 01m 37s
Commit git commit 27cf727608 ℹ️: Merge c0abd7f161fa0f85b9ef981a7c5e972af700e1c7 into 5250c2ad365622db1b7c1f2c26d0...
Committer Joseph Rhoads
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 47
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants