-
Notifications
You must be signed in to change notification settings - Fork 3
Bump vega-lite dependency #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughDependency version bump for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: test / cypress (4)
- GitHub Check: test / cypress (1)
- GitHub Check: test / cypress (3)
- GitHub Check: test / cypress (5)
- GitHub Check: test / cypress (2)
| "vega": "^6.2.0", | ||
| "vega-embed": "^6.25.0", | ||
| "vega-lite": "^5.19.0", | ||
| "vega-lite": "^6.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify react-vega compatibility and breaking changes before merging vega-lite 6.x.
This is a major version upgrade (5.x → 6.x) with breaking changes. Key concerns:
-
react-vega 7.6.0 supports both vega and vega-lite, but there is no explicit documentation confirming it was tested with vega-lite 6.x. Altair 6.0.0 required a major version bump to support vega-lite 6.1.0, suggesting other libraries may need updates for compatibility.
-
Breaking changes have been identified in vega-lite 6.x. Verify that any vega-lite specifications in the codebase are compatible with the new version (schema changes, deprecated APIs, etc.).
-
Test the application thoroughly after the upgrade to ensure all vega-lite visualizations render correctly and functionality is preserved.
🤖 Prompt for AI Agents
In package.json around line 81, the dependency bump to "vega-lite": "^6.1" is a
major upgrade with breaking changes and potential incompatibility with
react-vega; verify compatibility by (1) checking react-vega release notes and
code for explicit support of vega-lite 6.x or plan to upgrade react-vega if a
newer compatible release exists, (2) searching the repo for all vega-lite specs
and updating any schema/deprecated fields to the 6.x schema, (3) running
unit/integration/visual tests and manually validating key visualizations in the
app, and (4) if immediate compatibility isn’t confirmed, revert or pin vega-lite
to the last known-good 5.x version and add tests or CI visual snapshots before
re-attempting the major upgrade.
akita
|
||||||||||||||||||||||||||||
| Project |
akita
|
| Branch Review |
upgrade-vega-lite
|
| Run status |
|
| Run duration | 01m 37s |
| Commit |
|
| Committer | Joseph Rhoads |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
3
|
|
|
0
|
|
|
47
|
| View all changes introduced in this branch ↗︎ | |
Purpose
This PR updates the
vega-litedependency to a newer version. This update includes several changes to the underlying dependencies thatvega-literelies on, such asvega-expression,vega-util, andyargs.Approach
The primary change is updating the
vega-litepackage to a version within the^6.1range. This has resulted in corresponding updates to several other packages, includingvega-expression,vega-util, andyargs, to ensure compatibility.Key Modifications
vega-litefrom^5.19.0to^6.1.vega-expressionfrom~5.1.1to^6.1.0.vega-utilfrom^1.17.2to^2.1.0.yargsfrom^17.7.2to^18.0.0.vega-event-selectorfrom~3.0.1to~4.0.0.Important Technical Details
The dependency updates have brought in newer versions of packages related to terminal output formatting and command-line argument parsing (e.g.,
cliui,string-width,strip-ansi,wrap-ansi,yargs-parser). These updates are generally improvements and should not introduce breaking changes to the application's core functionality.Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Dependency Upgrade
Reviewer, please remember our guidelines:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.