Skip to content

Conversation

@jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Aug 14, 2024

Purpose

Use a different network visualization library that can visualize self-linking nodes.

closes: Add github issue that originated this PR

Approach

Renders most of the visualization on the server using pyvis then sends over the node, edge, and options from the pyvis visualization over to the nextjs application which then uses a component to render the network with vis-network.js

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@cypress
Copy link

cypress bot commented Aug 14, 2024



Test summary

52 0 3 0Flakiness 1


Run details

Project akita
Status Passed
Commit ab0f904 ℹ️
Started Aug 14, 2024 3:23 PM
Ended Aug 14, 2024 3:25 PM
Duration 01:45 💡
OS Linux Ubuntu -
Browser Electron 114

View run in Cypress Cloud ➡️


Flakiness

cypress/e2e/fundrefContainer.test.ts Flakiness
1 FundrefContainer > not in ror

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@jrhoads jrhoads requested review from a team, bklaing2 and digitaldogsbody August 14, 2024 15:26
Copy link
Member

@digitaldogsbody digitaldogsbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. At some point it might be worth considering pinning the versions of the Python libraries in the requirements file to make sure that current functionality is reproducible in all environments.

@jrhoads jrhoads marked this pull request as draft August 16, 2024 09:41
@jrhoads
Copy link
Contributor Author

jrhoads commented Aug 16, 2024

This is on pause pending further scoping in conjunction with product team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants