Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/r-intro-geospatial/compare/md-outputs..md-outputs-PR-149 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2026-02-02 17:15:28 +0000 |
Co-authored-by: Michael Mahoney <mike.mahoney.218@gmail.com>
|
Can I close this PR, @mikemahoney218? |
|
Sorry, I've been particularly busy recently and haven't had a chance to look this over -- I'll try to check it out this week (unless @likeajumprope gets to it first of course!) |
|
@albhasan and @mikemahoney218 should ^ be merged? |
|
Hey @kristi-sara, I wrote the PR, so I guess it should. However, it would be better if a maintainer checks it first. Bests, |
Grammar improvement. Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
|
@sstevens2 I think this is ready. Please take a look and if it is actually ready, can you please merge it? |
sstevens2
left a comment
There was a problem hiding this comment.
This looks really good to me! I added a couple of small changes. My earlier changes removed the mention of "vector recycling" so the definition didn't have any context around it. I added back in the term with the short definition and then made the longer definition a spoiler since it isn't as vital to the lesson with the short description.
@albhasan I'm not a maintainer on this lesson, only an active instructor of it. I can't merge the PR.
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
|
@sstevens2 Thanks for your contributions! I'm gonna ask a mantainer for a review and commit. Thanks again! |
|
Good morning, I think this PR has been open for too long. Can a maintainer please review it and, given the case, close it? @datacarpentry/r-intro-geospatial-maintainers Bests, |
coopermkr
left a comment
There was a problem hiding this comment.
This addition looks great! There are a few minor spelling mistakes that I left comments on. Once those are fixed this is approved for merging.
|
Thanks @coopermkr - I fixed the typos! I'm going to wait a couple of days just in case we receive more suggestions, and then I'm going to merge and close this PR. |
Closes #118
This PR:
typeofandna.omit.These changes addresses the issues raised by @sstevens2, regarding objectives missed by lesson 4.