Skip to content

Add new section to lesson 4#149

Open
albhasan wants to merge 16 commits intodatacarpentry:mainfrom
albhasan:keypoints_lesson_4
Open

Add new section to lesson 4#149
albhasan wants to merge 16 commits intodatacarpentry:mainfrom
albhasan:keypoints_lesson_4

Conversation

@albhasan
Copy link
Contributor

Closes #118

This PR:

  • adds a new section about removing columns and rows from data frames.
  • adds an example and a reference to the functions typeof and na.omit.

These changes addresses the issues raised by @sstevens2, regarding objectives missed by lesson 4.

@github-actions
Copy link

github-actions bot commented Nov 19, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/r-intro-geospatial/compare/md-outputs..md-outputs-PR-149

The following changes were observed in the rendered markdown documents:

 04-data-structures-part2.md | 136 +++++++++++++++++++++++++++++++++++++++++++-
 md5sum.txt                  |   2 +-
 2 files changed, 136 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2026-02-02 17:15:28 +0000

github-actions bot pushed a commit that referenced this pull request Nov 19, 2023
Co-authored-by: Michael Mahoney <mike.mahoney.218@gmail.com>
github-actions bot pushed a commit that referenced this pull request Jan 11, 2024
@albhasan
Copy link
Contributor Author

Can I close this PR, @mikemahoney218?

@mikemahoney218
Copy link
Member

Sorry, I've been particularly busy recently and haven't had a chance to look this over -- I'll try to check it out this week (unless @likeajumprope gets to it first of course!)

@kristi-sara
Copy link
Contributor

@albhasan and @mikemahoney218 should ^ be merged?

@albhasan
Copy link
Contributor Author

Hey @kristi-sara,

I wrote the PR, so I guess it should. However, it would be better if a maintainer checks it first.

Bests,

Grammar improvement.

Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
github-actions bot pushed a commit that referenced this pull request Nov 26, 2025
albhasan and others added 3 commits November 26, 2025 13:50
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
github-actions bot pushed a commit that referenced this pull request Nov 26, 2025
github-actions bot pushed a commit that referenced this pull request Jan 6, 2026
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
github-actions bot pushed a commit that referenced this pull request Jan 6, 2026
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
github-actions bot pushed a commit that referenced this pull request Jan 7, 2026
albhasan and others added 3 commits January 7, 2026 10:38
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
github-actions bot pushed a commit that referenced this pull request Jan 7, 2026
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
github-actions bot pushed a commit that referenced this pull request Jan 7, 2026
@albhasan
Copy link
Contributor Author

albhasan commented Jan 7, 2026

@sstevens2 I think this is ready. Please take a look and if it is actually ready, can you please merge it?

Copy link
Contributor

@sstevens2 sstevens2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good to me! I added a couple of small changes. My earlier changes removed the mention of "vector recycling" so the definition didn't have any context around it. I added back in the term with the short definition and then made the longer definition a spoiler since it isn't as vital to the lesson with the short description.

@albhasan I'm not a maintainer on this lesson, only an active instructor of it. I can't merge the PR.

albhasan and others added 2 commits January 22, 2026 13:22
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
github-actions bot pushed a commit that referenced this pull request Jan 22, 2026
@albhasan albhasan requested a review from sstevens2 January 22, 2026 16:35
@albhasan
Copy link
Contributor Author

@sstevens2 Thanks for your contributions!

I'm gonna ask a mantainer for a review and commit. Thanks again!

@albhasan
Copy link
Contributor Author

albhasan commented Feb 1, 2026

Good morning,

I think this PR has been open for too long. Can a maintainer please review it and, given the case, close it?

@datacarpentry/r-intro-geospatial-maintainers
@kristi-sara
@likeajumprope
@coopermkr
@mikemahoney218

Bests,

Copy link
Contributor

@coopermkr coopermkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition looks great! There are a few minor spelling mistakes that I left comments on. Once those are fixed this is approved for merging.

github-actions bot pushed a commit that referenced this pull request Feb 2, 2026
@albhasan
Copy link
Contributor Author

albhasan commented Feb 2, 2026

Thanks @coopermkr - I fixed the typos! I'm going to wait a couple of days just in case we receive more suggestions, and then I'm going to merge and close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keypoints and objectives don't match for Exploring Data Frames episode

5 participants