Skip to content

Address failing test: test_runtime_backend_errors_handled#492

Merged
sundarshankar89 merged 4 commits intomainfrom
fix/runtime-backend-errors
Mar 13, 2026
Merged

Address failing test: test_runtime_backend_errors_handled#492
sundarshankar89 merged 4 commits intomainfrom
fix/runtime-backend-errors

Conversation

@asnare
Copy link
Contributor

@asnare asnare commented Mar 6, 2026

This PR addresses a failing test: test_runtime_backend_errors_handled

This test checks error-handling, but one of the scenarios started failing under CI/CD because the test assumed it couldn't do something. Environment permissions have been updated, which means that it could and the error wasn't triggered. This PR modifies the scenario so that it will always produce an error.

Resolves #489.

Incidental changes:

  • Improve the identification of the parametrised tests.
  • Upgrade Hatch from 1.9.4 to 1.16.5, without which the tests can't be run.

@asnare asnare self-assigned this Mar 6, 2026
@asnare asnare added the internal label Mar 6, 2026
@asnare asnare added this to UCX Mar 6, 2026
@asnare asnare moved this to In Progress in UCX Mar 6, 2026
@asnare asnare changed the title Fix/runtime backend errors Address failing test: test_runtime_backend_errors_handled Mar 6, 2026
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

✅ 37/37 passed, 4 skipped, 4m27s total

Running from acceptance #562

The prior way assumed we didn't have certain permissions, but CI/CD does have them.
@asnare asnare moved this from In Progress to Ready for Review in UCX Mar 6, 2026
@asnare
Copy link
Contributor Author

asnare commented Mar 6, 2026

❌ 34/36 passed, 2 failed, 4 skipped, 4m46s total

❌ test_dashboards_creates_exported_dashboard_definition: assert {'datasets': ...: 'queries'}]} == {'datasets': ...: 'queries'}]} (2.078s)
❌ test_dashboard_deploys_dashboard_the_same_as_created_dashboard: AssertionError: assert {'datasets': ...uNFpooBTnT'}]} == {'datasets': ...uNFpooBTnT'}]} (2.144s)
Running from acceptance #553

These tests fail on main, and are unrelated to this PR. (They are addressed by #491.)

Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sundarshankar89 sundarshankar89 merged commit 90bf49a into main Mar 13, 2026
10 checks passed
@sundarshankar89 sundarshankar89 deleted the fix/runtime-backend-errors branch March 13, 2026 08:23
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in UCX Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal

Projects

Status: Done

2 participants