Skip to content

Eliminate test dependency: numpy#2334

Open
asnare wants to merge 2 commits intomainfrom
drop-numpy-usage
Open

Eliminate test dependency: numpy#2334
asnare wants to merge 2 commits intomainfrom
drop-numpy-usage

Conversation

@asnare
Copy link
Contributor

@asnare asnare commented Mar 12, 2026

Changes

What does this PR do?

This PR eliminates numpy as a (direct) project dependency: we're only using it in one specific location in a test, and it can be trivially replaced with code from the standard library.

It's worth removing: compatibility with other dependencies restricts us to a really old version, and for some of the supported platforms (and python versions) there's no prebuilt package available. This leads to unnecessarily long test/CI because numpy needs to be compiled from source during (virtual) environment setup.

Caveats/things to watch out for when reviewing:

The integration test that runs the updated pipeline is: test_profile_execution_config_override

Tests

  • modified integration test

Although only used in tests, for some of our supported architecture/python combinations there's no pre-built package and it needs to be compiled for the environment.
@asnare asnare self-assigned this Mar 12, 2026
@asnare asnare added the dependencies Pull requests that update a dependency file label Mar 12, 2026
@asnare asnare requested a review from a team as a code owner March 12, 2026 12:50
@asnare asnare added tech debt design flaws and other cascading effects internal technical pr's not end user facing labels Mar 12, 2026
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.41%. Comparing base (af61713) to head (a851982).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2334   +/-   ##
=======================================
  Coverage   66.41%   66.41%           
=======================================
  Files          99       99           
  Lines        9094     9094           
  Branches      974      974           
=======================================
  Hits         6040     6040           
  Misses       2878     2878           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

✅ 145/145 passed, 7 flaky, 4 skipped, 39m37s total

Flaky tests:

  • 🤪 test_installs_and_runs_pypi_bladebridge (28.148s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[True] (16.67s)
  • 🤪 test_transpiles_informatica_to_sparksql (18.212s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[False] (4.214s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (21.629s)
  • 🤪 test_transpile_teradata_sql (6.459s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (5.898s)

Running from acceptance #4038

Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file internal technical pr's not end user facing tech debt design flaws and other cascading effects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants