Conversation
Although only used in tests, for some of our supported architecture/python combinations there's no pre-built package and it needs to be compiled for the environment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2334 +/- ##
=======================================
Coverage 66.41% 66.41%
=======================================
Files 99 99
Lines 9094 9094
Branches 974 974
=======================================
Hits 6040 6040
Misses 2878 2878
Partials 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 145/145 passed, 7 flaky, 4 skipped, 39m37s total Flaky tests:
Running from acceptance #4038 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
This PR eliminates
numpyas a (direct) project dependency: we're only using it in one specific location in a test, and it can be trivially replaced with code from the standard library.It's worth removing: compatibility with other dependencies restricts us to a really old version, and for some of the supported platforms (and python versions) there's no prebuilt package available. This leads to unnecessarily long test/CI because numpy needs to be compiled from source during (virtual) environment setup.
Caveats/things to watch out for when reviewing:
The integration test that runs the updated pipeline is:
test_profile_execution_config_overrideTests