Open
Conversation
This also means upgrading pytest-asyncio. (The other plugins are already up-to-date.)
…d ruff. This is easier to modify with matrix templating.
This includes some changes to the source, and sadly some suppressions for naming conventions that are wrong but user-exposed.
… rather than just using the system python.
…lier to the cache) than using the version under test.
|
✅ 145/145 passed, 6 flaky, 4 skipped, 44m45s total Flaky tests:
Running from acceptance #4036 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2333 +/- ##
=======================================
Coverage 66.41% 66.42%
=======================================
Files 99 99
Lines 9094 9102 +8
Branches 974 977 +3
=======================================
+ Hits 6040 6046 +6
- Misses 2878 2880 +2
Partials 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is the latest version that still supports python 3.10.
This allows the Hatch environment to be selected via the environment variable.
Arguably we should remove the embedded wheel entirely, but that's a discussion for another day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
This PR updates this project so that the CLI supports Python 3.14. Aside the from the project metadata, this involved:
mypy,pylintandpytestthat work properly with python 3.14. Some code-changes were required to satisfy the new versions of these tools.Relevant implementation details
Downstream dependencies have already been released with support for Python 3.14:
The
pytesterandlsqldependencies already work with python 3.14, although those projects also have tooling updates to ensure that CI/CD tests it explicitly. The changes in this PR broadly match those from those repositories.A further improvement here is integration testing across the python version matrix.
Caveats/things to watch out for when reviewing:
We have our first system imports that depend on the version of python:
importlib.abc.Traversablewas moved toimportlib.abs.resources.Traversablein Python 3.11, with the old location deprecated and removed in 3.14.The changes to
.codegen.jsonare aimed at ensuring that thelabsrunner (used to run integration tests) honours supports the use ofHATCH_ENVto choose which Hatch environment should be used to run the tests. This is needed for the integration-testing matrix introduced by this PR.@gueniai: Due to the expanded unit and integration tests, the set of mandatory checks on PRs for this repository will need to be adjusted.
Linked issues
Resolves #2137.
Functionality
updated relevant user documentation
modifies existing commands:
databricks labs install lakebridgedatabricks labs lakebridge install-transpileTests