Skip to content

Update Profiler Dashboard Templates#2317

Merged
gueniai merged 6 commits intomainfrom
feature/add_profiler_dashboards
Mar 6, 2026
Merged

Update Profiler Dashboard Templates#2317
gueniai merged 6 commits intomainfrom
feature/add_profiler_dashboards

Conversation

@goodwillpunning
Copy link
Contributor

@goodwillpunning goodwillpunning commented Feb 28, 2026

Changes

What does this PR do?

Updates the profiler summary dashboard template for Azure Synapse and adds a dashboard template for MSSQL.

Relevant implementation details

This PR updates adds a new dashboard template for MSSQL and updates the Azure Synapse profiler dashboard with the following fixes:

  1. Remove widget parameters deprecated in Lakeview dashboards
  2. Parameterizes table values so that they can be dynamically set by Lakebridge
  3. Adds a new visualization for a summary of dedicated storage info by SQL pool name
  4. Updates the dataset names with more descriptive titles
  5. Fixes broken column names in SQL Pool activity visualizations
  6. Adds proper SQL formatting to dataset queries

Caveats/things to watch out for when reviewing:

Linked issues

N/A

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs lakebridge create-profiler-dashboard
  • ... +add your own

Tests

  • manually tested
  • added unit tests
  • added integration tests

@codecov
Copy link

codecov bot commented Feb 28, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.41%. Comparing base (41c3f9a) to head (8ea27a7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...bridge/assessments/dashboards/dashboard_manager.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2317   +/-   ##
=======================================
  Coverage   66.41%   66.41%           
=======================================
  Files          99       99           
  Lines        9094     9094           
  Branches      974      974           
=======================================
  Hits         6040     6040           
  Misses       2878     2878           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Feb 28, 2026

✅ 145/145 passed, 5 flaky, 4 skipped, 53m20s total

Flaky tests:

  • 🤪 test_installs_and_runs_local_bladebridge (21.633s)
  • 🤪 test_transpiles_informatica_to_sparksql (18.088s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (6.672s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (6.12s)
  • 🤪 test_transpile_teradata_sql (16.275s)

Running from acceptance #4004

@goodwillpunning goodwillpunning changed the title Update Profiler Synapse Profiler Dashboard Update Profiler Dashboard Templates Mar 1, 2026
Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see #2319 changes the dashboard_manager.py, Since I came from there I m confused with the direction of the PR and left a detailed comment on how I think we can approacht this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't match the new file name pattern. it should be rather

Suggested change
filename = f"lakebridge_{source_system.lower()}_profiler_summary.lvdash.json "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Artifact from late night coding. This has been updated.

logging.info(f"Loading dashboard template from folder: {folder}")
dash_reference = f"{folder.stem}".lower()
dashboard_loader = DashboardTemplateLoader(folder)
dashboard_json = dashboard_loader.load(source_system="synapse")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source_system needs to be a argument to the public method

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is addressed in PR#2319. This PR only updates the dashboard templates.

Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits: but lgtm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: all logging needs to be changed to logger in this file

Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gueniai gueniai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gueniai gueniai added this pull request to the merge queue Mar 6, 2026
Merged via the queue into main with commit 7ff77c2 Mar 6, 2026
6 checks passed
@gueniai gueniai deleted the feature/add_profiler_dashboards branch March 6, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat/profiler Issues related to profilers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants