Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2317 +/- ##
=======================================
Coverage 66.41% 66.41%
=======================================
Files 99 99
Lines 9094 9094
Branches 974 974
=======================================
Hits 6040 6040
Misses 2878 2878
Partials 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 145/145 passed, 5 flaky, 4 skipped, 53m20s total Flaky tests:
Running from acceptance #4004 |
sundarshankar89
left a comment
There was a problem hiding this comment.
I see #2319 changes the dashboard_manager.py, Since I came from there I m confused with the direction of the PR and left a detailed comment on how I think we can approacht this.
There was a problem hiding this comment.
this doesn't match the new file name pattern. it should be rather
| filename = f"lakebridge_{source_system.lower()}_profiler_summary.lvdash.json " |
There was a problem hiding this comment.
Good catch! Artifact from late night coding. This has been updated.
| logging.info(f"Loading dashboard template from folder: {folder}") | ||
| dash_reference = f"{folder.stem}".lower() | ||
| dashboard_loader = DashboardTemplateLoader(folder) | ||
| dashboard_json = dashboard_loader.load(source_system="synapse") |
There was a problem hiding this comment.
source_system needs to be a argument to the public method
There was a problem hiding this comment.
This is addressed in PR#2319. This PR only updates the dashboard templates.
sundarshankar89
left a comment
There was a problem hiding this comment.
small nits: but lgtm
There was a problem hiding this comment.
small nit: all logging needs to be changed to logger in this file
Changes
What does this PR do?
Updates the profiler summary dashboard template for Azure Synapse and adds a dashboard template for MSSQL.
Relevant implementation details
This PR updates adds a new dashboard template for MSSQL and updates the Azure Synapse profiler dashboard with the following fixes:
Caveats/things to watch out for when reviewing:
Linked issues
N/A
Functionality
databricks labs lakebridge create-profiler-dashboardTests