Tooling updates: hatch, mypy, pylint, pytest #323
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 80.07% 80.11% +0.04%
==========================================
Files 17 17
Lines 2474 2474
Branches 533 403 -130
==========================================
+ Hits 1981 1982 +1
Misses 364 364
+ Partials 129 128 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Multiple tests trigger `cmd` registration, and these accumulate without resetting. This test was therefore flaky, depending on the order in which tests run. (Type hints are also fully implemented.)
asnare
requested review from
FastLee,
gueniai,
m-abulazm,
pritishpai and
sundarshankar89
|
✅ 40/40 passed, 2 skipped, 1m39s total Running from acceptance #383 |
asnare
changed the title
mypy, pylint, pytest hatch, mypy, pylint, pytest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the versions of some of our tools used for project linting and tests:
Further to this, an unreliable test was fixed:
test_user_agent_is_propagated: was sensitive to the side-effects of other tests that register CLI commands: user-agent updates are cumulative and global.