Add Support for bool type fields serialization and deserialization#268
Add Support for bool type fields serialization and deserialization#268sundarshankar89 wants to merge 14 commits intomainfrom
Conversation
|
✅ 40/40 passed, 2 skipped, 1m29s total Running from acceptance #384 |
tests/unit/test_installation.py
Outdated
| __version__ = 3 | ||
| skip_validation: bool = True |
There was a problem hiding this comment.
Can we also check the False case?
There was a problem hiding this comment.
Fixed, I added another example in the same tests.
Or do you want to default to be False ?
There was a problem hiding this comment.
All I wanted was both values to be checked, just to shake out any issues with 'truthy' logic that might be present elsewhere.
(The area of logic modified by this PR contains lots of checks for different things, and in some ways they're co-dependent: an early branch means that later branches might not be reached when they should.)
tests/unit/test_installation.py
Outdated
| __version__ = 3 | ||
| skip_validation: bool = True |
There was a problem hiding this comment.
All I wanted was both values to be checked, just to shake out any issues with 'truthy' logic that might be present elsewhere.
(The area of logic modified by this PR contains lots of checks for different things, and in some ways they're co-dependent: an early branch means that later branches might not be reached when they should.)
tests/unit/test_installation.py
Outdated
| skip_validation: bool = True | ||
| sdk_config: JsonValue = None |
There was a problem hiding this comment.
Some nits:
- Drop the default values.
- I don't understand the meaning of
MissingAttributein the name. MaybeBooleanAttributeClass. - Maybe
kw_only=True(useful for boolean and integer properties on data classes).
What do you think?
asnare
left a comment
There was a problem hiding this comment.
Also, we can't merge or release with those downstream UCX failures… do you understand why they're happening?
|
@asnare |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
- Coverage 80.11% 80.03% -0.09%
==========================================
Files 17 17
Lines 2474 2474
Branches 403 403
==========================================
- Hits 1982 1980 -2
- Misses 364 365 +1
- Partials 128 129 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.