[Go] Add experimental Arrow Flight ingestion support#134
Open
elenagaljak-db wants to merge 2 commits intomainfrom
Open
[Go] Add experimental Arrow Flight ingestion support#134elenagaljak-db wants to merge 2 commits intomainfrom
elenagaljak-db wants to merge 2 commits intomainfrom
Conversation
elenagaljak-db
force-pushed
the
arrow_go
branch
from
12a468e to
d27b06f
Compare
elenagaljak-db
changed the title
Comment on lines
+193
to
+196
| ipcCompression := opts.IPCCompression | ||
| if ipcCompression == 0 && opts.IPCCompression == 0 { | ||
| ipcCompression = d.IPCCompression | ||
| } |
Contributor
There was a problem hiding this comment.
As we define this:
const (
// IPCCompressionNone disables Arrow IPC compression (default).
IPCCompressionNone int32 = -1
// IPCCompressionLZ4Frame enables LZ4 frame compression.
IPCCompressionLZ4Frame int32 = 0
// IPCCompressionZstd enables Zstandard compression.
IPCCompressionZstd int32 = 1
)
wouldn't this mean that if user requests lz4 compression (as thats 0) will get reverted to using None (as thats the default value)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Adds Arrow Flight ingestion to the Go SDK via new C FFI bindings into the Rust layer. The Go side serializes Arrow RecordBatches to IPC bytes, passes them zero-copy across the FFI boundary, and the
Rust SDK handles encoding, framing, and transmission over the Arrow Flight gRPC protocol.
How is this tested?
Existing tests and added test with mock server