Skip to content

Avoid a warning in covid_trends_job.py#9

Open
lennartkats-db wants to merge 1 commit intodatabricks:mainfrom
lennartkats-db:patch-1
Open

Avoid a warning in covid_trends_job.py#9
lennartkats-db wants to merge 1 commit intodatabricks:mainfrom
lennartkats-db:patch-1

Conversation

@lennartkats-db
Copy link
Copy Markdown

@lennartkats-db lennartkats-db commented Oct 26, 2022

Using a PEP 484 "# type: ignore" annotation

I do wonder if we really want to use that global, though? Is that a best practice? In the past I used something like spark = SparkSession.builder.getOrCreate()

Using a PEP 484 "# type: ignore" annotation
@fjakobs
Copy link
Copy Markdown
Collaborator

fjakobs commented Oct 28, 2022

I would rather replace this line with

spark = SparkSession.builder.getOrCreate() since this is the refactored code that should follow best practices.

@fjakobs
Copy link
Copy Markdown
Collaborator

fjakobs commented Oct 31, 2022

#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants