Add GitHub OIDC authentication support#444
Merged
parthban-db merged 14 commits intomainfrom May 13, 2025
Merged
Conversation
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
changed the title
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
approved these changes
May 9, 2025
Contributor
renaudhartert-db
left a comment
renaudhartert-db
left a comment
There was a problem hiding this comment.
LGTM overall, deferring approval to @parthban-db
databricks-sdk-java/src/main/java/com/databricks/sdk/core/DefaultCredentialsProvider.java
Show resolved
Hide resolved
parthban-db
reviewed
May 10, 2025
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/GithubIDTokenSource.java
Outdated
Show resolved
Hide resolved
databricks-sdk-java/src/test/java/com/databricks/sdk/DatabricksAuthManualTest.java
Outdated
Show resolved
Hide resolved
databricks-sdk-java/src/main/java/com/databricks/sdk/core/DefaultCredentialsProvider.java
Outdated
Show resolved
Hide resolved
databricks-sdk-java/src/test/java/com/databricks/sdk/core/oauth/GithubIDTokenSourceTest.java
Outdated
Show resolved
Hide resolved
databricks-sdk-java/src/main/java/com/databricks/sdk/core/oauth/GithubIDTokenSource.java
Outdated
Show resolved
Hide resolved
databricks-sdk-java/src/main/java/com/databricks/sdk/core/DefaultCredentialsProvider.java
Outdated
Show resolved
Hide resolved
databricks-sdk-java/src/main/java/com/databricks/sdk/core/DefaultCredentialsProvider.java
Show resolved
Hide resolved
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
databricks-sdk-java/src/main/java/com/databricks/sdk/core/DefaultCredentialsProvider.java
Show resolved
Hide resolved
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
hectorcast-db
approved these changes
May 12, 2025
…ultCredentialsProvider.java Co-authored-by: Renaud Hartert <renaud.hartert@databricks.com>
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
parthban-db
reviewed
May 12, 2025
databricks-sdk-java/src/test/java/com/databricks/sdk/DatabricksAuthManualTest.java
Show resolved
Hide resolved
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
emmyzhou-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
parthban-db
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR adds support for GitHub OIDC (OpenID Connect) authentication in the Databricks SDK Java.
Key Changes
GithubIDTokenSourceto retrieve JWT tokens from GitHub Actions environmentTokenSourceCredentialsProvideras a generic provider for token-based authentication flowsDefaultCredentialsProviderto support GitHub OIDC and restructured it to facilitate adding other identity providersHow is this tested?
GithubIDTokenSourceandTokenSourceCredentialsProviderNO_CHANGELOG=true