Remove dev prefix in config-remote-sync when resource is renamed#4919
Open
ilyakuz-db wants to merge 1 commit intomainfrom
Open
Remove dev prefix in config-remote-sync when resource is renamed#4919ilyakuz-db wants to merge 1 commit intomainfrom
ilyakuz-db wants to merge 1 commit intomainfrom
Conversation
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: high Eligible reviewersBased on OWNERS, these people or teams could also review: @andrewnester, @anton-107, @pietern, @shreyas-goenka, @simonfaltum Suggestions based on git history of 8 changed files (1 scored). See OWNERS for path-specific ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove current dev-prefix when config-remote-sync applies resource name changes to avoid duplicating it in the config
Why
If we don't do that users always need to remove dev prefix manually even for simple renames like
[prefix] foo_1 => [prefix] foo_2. If they don't do it that leads to job names like this:[dev username] [dev username] my_jobTests
Update acceptance tests