Merged
Conversation
janniklasrose
requested review from
andrewnester,
anton-107,
denik,
pietern,
shreyas-goenka and
simonfaltum
as code owners
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: high Eligible reviewersBased on OWNERS, these people or teams could also review: @andrewnester, @anton-107, @pietern, @shreyas-goenka, @simonfaltum Suggestions based on git history of 5 changed files (3 scored). See OWNERS for path-specific ownership rules. |
janniklasrose
commented
Apr 8, 2026
Comment on lines
+5
to
+6
| trace $CLI bundle validate -o json -t override-lookup-variable-with-value | jq .variables.w_lookup.value | ||
| trace $CLI bundle validate -o json -t override-lookup-variable-with-lookup | jq .variables.w_lookup.value |
Contributor
Author
There was a problem hiding this comment.
.variables.w_lookup.value because the value isn't being used in .resources - didn't want to change the whole bundle definition with something that supports lookup
andrewnester
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove lookup if explicit override exists for target
Why
Fixes #4915
Documentation says the order is:
4. Within any
variablesmappings, among thetargetsmappings within your bundle configuration files.5. Any
defaultvalue for that variable's definition, among the top-levelvariablesmappings within your bundle configuration files.Tests
Added unit and acceptance tests