Fix maintainer-approval runner and clean up OWNERS#4914
Merged
simonfaltum merged 3 commits intomainfrom Apr 8, 2026
Merged
Conversation
Simon is already covered by the * catch-all rule. Listing him explicitly on /cmd/bundle/ is redundant. This PR also serves to verify the maintainer-approval and suggest-reviewers workflows added in #4912.
simonfaltum
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
Suggested reviewerCould not determine reviewers from git history. Eligible reviewersBased on OWNERS, these people or teams could also review: @andrewnester, @denik, @pietern, @shreyas-goenka Suggestions based on git history of 1 changed files (0 scored). See OWNERS for path-specific ownership rules. |
simonfaltum
changed the title
The databricks org has an IP allow-list that blocks GitHub public runners from making API calls. Use the same custom runner group as the other workflows in this repo.
simonfaltum
changed the title
parthban-db
approved these changes
Apr 8, 2026
mihaimitrea-db
approved these changes
Apr 8, 2026
The error message said 'core team member' which is an internal concept. Use 'maintainer' instead, matching the workflow name and the OWNERS file terminology.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The maintainer-approval workflow from #4912 used
ubuntu-latest(GitHub public runners), which can't make API calls against thedatabricksorg due to the IP allow-list. Also,@simonfaltumwas listed on the/cmd/bundle/OWNERS rule but isn't on the bundle team.Changes
maintainer-approval.ymlfromubuntu-latestto thedatabricks-deco-testing-runner-groupcustom runner, matching all other workflows in the repo.@simonfaltumfrom/cmd/bundle/in.github/OWNERSsince he's not on the bundle team.Test plan
suggest-reviewers / suggest-reviewersfired and posted a reviewer suggestion comment with round-robin fallbackMaintainer approval / checkruns on the custom runner (requires a new PR sincepull_request_targetreads workflows from the base branch)