Skip to content

Use filter option with service principal API when lookup variable used#4913

Merged
andrewnester merged 4 commits intomainfrom
fix/sp-list-filter
Apr 8, 2026
Merged

Use filter option with service principal API when lookup variable used#4913
andrewnester merged 4 commits intomainfrom
fix/sp-list-filter

Conversation

@andrewnester
Copy link
Copy Markdown
Contributor

Changes

Use filter option with service principal API when lookup variable used

Why

Previously we were listing all SPs in the workspace which can be very slow. Using filter option in API allows to filter out the result quicker/

Tests

Updated unit test

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Suggested reviewers

Based on git history of the changed files, these people are best suited to review:

Confidence: medium

Eligible reviewers

Based on CODEOWNERS, these people or teams could also review:

@anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum

Suggestions based on git history of 2 changed files (2 scored). See CODEOWNERS for path-specific ownership rules.

Copy link
Copy Markdown
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a cloud acc test for this?

Getting the syntax right for filtering is important.

@andrewnester
Copy link
Copy Markdown
Contributor Author

@pietern 100% agree, added cloud test here fadcb19

@andrewnester andrewnester enabled auto-merge April 8, 2026 14:58
@andrewnester andrewnester added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit 1c84f9f Apr 8, 2026
18 checks passed
@andrewnester andrewnester deleted the fix/sp-list-filter branch April 8, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants