Skip dummy subtest when EnvMatrix expands to empty#4893
Merged
Conversation
When all EnvMatrix values are empty lists (e.g., DATABRICKS_BUNDLE_ENGINE = []), run the test directly without creating a "#00" dummy subtest. Add selftests for empty EnvMatrix and mixed EnvMatrix (some vars with values, some empty). Task: 001.md Co-authored-by: Isaac
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: low Eligible reviewersBased on CODEOWNERS, these people or teams could also review: @andrewnester, @anton-107, @pietern, @simonfaltum Suggestions based on git history of 9 changed files (1 scored). See CODEOWNERS for path-specific ownership rules. |
pietern
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When all EnvMatrix values are empty lists (e.g.,
DATABRICKS_BUNDLE_ENGINE = []), run the test directly without creating a#00dummy subtest.Before:
After:
This allows tests to opt out of the default engine matrix by setting
DATABRICKS_BUNDLE_ENGINE = []without creating a confusingly-named subtest.Tests
Added selftests:
selftest/envmatrix_empty— verifies no subtest is created when all EnvMatrix values are emptyselftest/envmatrix_mixed— verifies empty vars are dropped while non-empty vars still create subtests