Skip to content

Skip dummy subtest when EnvMatrix expands to empty#4893

Merged
denik merged 1 commit intomainfrom
denik/envmatrix-empty
Apr 2, 2026
Merged

Skip dummy subtest when EnvMatrix expands to empty#4893
denik merged 1 commit intomainfrom
denik/envmatrix-empty

Conversation

@denik
Copy link
Copy Markdown
Contributor

@denik denik commented Apr 2, 2026

Changes

When all EnvMatrix values are empty lists (e.g., DATABRICKS_BUNDLE_ENGINE = []), run the test directly without creating a #00 dummy subtest.

Before:

--- PASS: TestAccept/bundle/foo (0.00s)
    --- PASS: TestAccept/bundle/foo/#00 (1.23s)

After:

--- PASS: TestAccept/bundle/foo (1.23s)

This allows tests to opt out of the default engine matrix by setting DATABRICKS_BUNDLE_ENGINE = [] without creating a confusingly-named subtest.

Tests

Added selftests:

  • selftest/envmatrix_empty — verifies no subtest is created when all EnvMatrix values are empty
  • selftest/envmatrix_mixed — verifies empty vars are dropped while non-empty vars still create subtests

When all EnvMatrix values are empty lists (e.g., DATABRICKS_BUNDLE_ENGINE = []),
run the test directly without creating a "#00" dummy subtest.

Add selftests for empty EnvMatrix and mixed EnvMatrix (some vars with values,
some empty).

Task: 001.md

Co-authored-by: Isaac
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Suggested reviewers

Based on git history of the changed files, these people are best suited to review:

Confidence: low

Eligible reviewers

Based on CODEOWNERS, these people or teams could also review:

@andrewnester, @anton-107, @pietern, @simonfaltum

Suggestions based on git history of 9 changed files (1 scored). See CODEOWNERS for path-specific ownership rules.

@denik denik merged commit c9cf556 into main Apr 2, 2026
16 of 17 checks passed
@denik denik deleted the denik/envmatrix-empty branch April 2, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants