Conversation
Co-authored-by: Isaac
Co-authored-by: Isaac
The hardened runner blocks direct access to public registries. Use JFrog Artifactory as a proxy with OIDC authentication. Co-authored-by: Isaac
The jf goc command only works with jf go, not native go commands. Set GOPROXY and .netrc for native go toolchain. Co-authored-by: Isaac
Replace jf config show (no JSON format flag) with direct OIDC token exchange, matching the pattern from the hardened runner docs for uv/cargo. Co-authored-by: Isaac
Use jf goc + jf go mod download to pre-populate the module cache via JFrog. Native go commands then work from cache. Co-authored-by: Isaac
Co-authored-by: Isaac
Collaborator
|
Commit: 5270413
19 interesting tests: 10 SKIP, 7 KNOWN, 2 flaky
Top 21 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac
The hardened runner doesn't have Node.js pre-installed, which is needed by the run-local-node acceptance test. Co-authored-by: Isaac
The test requires npm registry access which is blocked on the hardened runner. Disable until npm is routed through JFrog. Co-authored-by: Isaac
pietern
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
Co-authored-by: Isaac
pietern
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
The existing runners are already hardened, so no need to switch to the hardened-optin group. Co-authored-by: Isaac
pietern
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
Windows runners are also hardened and can't reach proxy.golang.org. Co-authored-by: Isaac
pietern
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
denik
approved these changes
Apr 1, 2026
PowerShell splits -modfile=tools/go.mod into separate tokens. Co-authored-by: Isaac
pietern
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
This ensures all test jobs that use the shared action get the JFrog Go module proxy configured on hardened runners. Co-authored-by: Isaac
pietern
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
…test jobs to custom runners Co-authored-by: Isaac
pietern
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
Co-authored-by: Isaac
pietern
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
andrewnester
approved these changes
Apr 1, 2026
pietern
requested review from
anton-107,
shreyas-goenka and
simonfaltum
as code owners
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: high Eligible reviewersBased on CODEOWNERS, these people or teams could also review: @andrewnester, @anton-107, @shreyas-goenka, @simonfaltum Suggestions based on git history of 6 changed files (5 scored). See CODEOWNERS for path-specific ownership rules. |
denik
reviewed
Apr 1, 2026
| @@ -1,5 +1,6 @@ | |||
| Badness = "need to enable NPM registry access" | |||
Contributor
There was a problem hiding this comment.
We should also consider vendoring dependencies here like we did with Python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run-local-nodeacceptance test (needs npm registry access via JFrog)Test plan
make testpasses on Linux, Windows, macOStest-exp-aitools,test-exp-ssh,test-pipelinesare triggered and passThis pull request was AI-assisted by Isaac.