Add GetResourceID to dstate and refactor callers#4862
Merged
Conversation
Adds GetResourceID(key) string returning the resource ID or empty string if not found, replacing the bool-returning GetResourceEntry in all callers that only needed the ID. Renames the implementation to getResourceEntry (unexported); keeps GetResourceEntry public for the one caller that also needs the State field. Co-authored-by: Isaac
denik
requested review from
andrewnester,
anton-107,
pietern,
shreyas-goenka and
simonfaltum
as code owners
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: low Eligible reviewersBased on CODEOWNERS, these people or teams could also review: @andrewnester, @anton-107, @pietern, @simonfaltum Suggestions based on git history of 5 changed files (4 scored). See CODEOWNERS for path-specific ownership rules. |
shreyas-goenka
approved these changes
Mar 27, 2026
Collaborator
|
Commit: 0f94be5
17 interesting tests: 10 SKIP, 7 KNOWN
Top 20 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: df16914
55 interesting tests: 22 flaky, 15 RECOVERED, 9 KNOWN, 7 FAIL, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds GetResourceID(key) string returning the resource ID or empty string if not found, replacing the bool-returning GetResourceEntry in all callers that only needed the ID. Renames the implementation to getResourceEntry (unexported); keeps GetResourceEntry public for the one caller that also needs the State field.
Why
Separate write users that only need access to ID and read users that need full state. Preparing for WAL.