Pin Alpine image digest and add SHA256 verification for TF provider#4849
Merged
shreyas-goenka merged 6 commits intomainfrom Mar 26, 2026
Merged
Pin Alpine image digest and add SHA256 verification for TF provider#4849shreyas-goenka merged 6 commits intomainfrom
shreyas-goenka merged 6 commits intomainfrom
Conversation
…ownload Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: faf0949
20 interesting tests: 10 SKIP, 7 KNOWN, 3 flaky
Top 20 slowest tests (at least 2 minutes):
|
The codegen tool (`go run .`) now automatically downloads the SHA256SUMS file from the GitHub release and embeds the checksums into the generated root.go. When bumping the provider version, developers only need to update version.go — checksums are resolved automatically. Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik,
pietern and
simonfaltum
as code owners
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: low Eligible reviewersBased on CODEOWNERS, these people or teams could also review: Suggestions based on git history of 10 changed files (6 scored). See CODEOWNERS for path-specific ownership rules. |
pietern
reviewed
Mar 26, 2026
These tests download large archives from the internet. Gate them behind `testing.Short()` so they're skipped during normal CI (`make test`) and only run in nightly/long test sessions. Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
…check Instead of a separate test that downloads large archives on every test run, verify the checksum inline during codegen: FetchProviderChecksums now downloads the linux_amd64 zip and verifies it matches the parsed SHA256SUMS entry. This runs once during `go run .` (provider version bump) rather than on every `make test`. Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Co-authored-by: Isaac
…egen Co-authored-by: Isaac
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alpine:3.22in Dockerfile to its@sha256digest for reproducible buildsdocker/setup.sh, matching the existing pattern for the TF binarygo run .) from the GitHub release SHA256SUMS file, so bumping the provider version inversion.gois the only manual step neededdatabricks bundle debug terraform --output jsonunderproviderChecksumTestTerraformArchiveChecksumsbehindtesting.Short()to avoid large downloads on every test runTest plan
go build ./...compiles cleanlygo test -short ./bundle/deploy/terraform/passesThis pull request was AI-assisted by Isaac.