acc: parameterize bundle name in job_permissions test to avoid stale deploy locks#4772
Merged
acc: parameterize bundle name in job_permissions test to avoid stale deploy locks#4772
Conversation
…deploy locks Use $UNIQUE_NAME for the bundle name so each test run gets a unique workspace root path, preventing lock conflicts from concurrent or repeated runs. Co-authored-by: Isaac
pietern
requested review from
andrewnester,
anton-107,
denik,
shreyas-goenka and
simonfaltum
as code owners
Collaborator
|
Commit: 45af624
18 interesting tests: 9 SKIP, 7 RECOVERED, 2 flaky
Top 26 slowest tests (at least 2 minutes):
|
denik
approved these changes
Mar 18, 2026
simonfaltum
reviewed
Mar 18, 2026
Member
simonfaltum
left a comment
simonfaltum
left a comment
There was a problem hiding this comment.
Review (automated, 2 agents)
Verdict: Approved
0 Critical | 0 Major | 0 Gap | 1 Nit | 1 Suggestion
See inline comments for details.
| @@ -1,5 +1,5 @@ | |||
| bundle: | |||
| name: test-bundle | |||
| name: $UNIQUE_NAME | |||
Member
There was a problem hiding this comment.
[Suggestion] App name my-app is still hardcoded
The bundle name is now parameterized (fixing deploy locks), but the app resource name my-app (line 24) remains hardcoded. If a prior run fails after creating the app but before bundle destroy, the next run could hit RESOURCE_ALREADY_EXISTS. The sibling tests (compute_size, git_source) already parameterize the app name as app-$UNIQUE_NAME and include cleanup traps.
This is orthogonal to the PR's stated goal (deploy locks are fixed correctly), but worth addressing as a follow-up for consistency with sibling tests.
Suggestion: Consider parameterizing the app name and adding a trap cleanup EXIT handler as a follow-up.
Collaborator
|
Commit: bbfbea2
89 interesting tests: 46 MISS, 16 RECOVERED, 12 KNOWN, 8 flaky, 4 FAIL, 2 PANIC, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
databricks.yml→databricks.yml.tmpland substitute$UNIQUE_NAMEas the bundle nameenvsubstcall in the test script to generatedatabricks.ymlbefore deployingoutput.txtto expect[UNIQUE_NAME]in workspace pathsThe test was using a hardcoded bundle name (
test-bundle), which meant all runs shared the same workspace root path (~/.bundle/test-bundle/default). When a run failed mid-way without cleaning up, the deploy lock persisted and blocked subsequent runs. Using$UNIQUE_NAME(injected per-run by the test framework) gives each run an isolated path.Test plan
go test ./acceptance -run TestAccept/bundle/apps/job_permissions -v -tail -updatelocally — bothterraformanddirectvariants passThis pull request was AI-assisted by Isaac.