-
Notifications
You must be signed in to change notification settings - Fork 155
Add WAL for direct deployment state recovery #4106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
varundeepsaini
wants to merge
9
commits into
databricks:main
Choose a base branch
from
varundeepsaini:feature/deploy-append-log
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
69f2cb2
Add WAL for direct deployment state recovery
2e40a21
Updated tests and enhanced kill caller with an offset
d844a9e
Updated existing tests
2392819
test fixes
fb149b6
Fixes
d3ce8b5
fixed tests
79ec8d6
updated tests
varundeepsaini 6e12ee1
dedup
varundeepsaini 6b1c292
Update WAL corrupted entry outputs
varundeepsaini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,5 @@ | ||
| RecordRequests = false | ||
|
|
||
| [[Repls]] | ||
| Old = 'Updating deployment state...\n' | ||
| New = '' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| Local = true | ||
| Cloud = false | ||
| RecordRequests = false | ||
|
|
||
| [[Repls]] | ||
| Old = 'Updating deployment state...\n' | ||
| New = '' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,5 @@ | ||
| Cloud=true | ||
|
|
||
| [[Repls]] | ||
| Old = 'Updating deployment state...\n' | ||
| New = '' |
117 changes: 117 additions & 0 deletions
117
acceptance/bundle/deploy/wal/chain-10-jobs/databricks.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| bundle: | ||
| name: wal-chain-test | ||
|
|
||
| resources: | ||
| jobs: | ||
| # Linear chain: job_01 -> job_02 -> ... -> job_10 | ||
| # Execution order: job_01 first, job_10 last | ||
| job_01: | ||
| name: "job-01" | ||
| description: "first in chain" | ||
| tasks: | ||
| - task_key: "task" | ||
| spark_python_task: | ||
| python_file: ./test.py | ||
| new_cluster: | ||
| spark_version: 15.4.x-scala2.12 | ||
| node_type_id: i3.xlarge | ||
| num_workers: 0 | ||
| job_02: | ||
| name: "job-02" | ||
| description: "depends on ${resources.jobs.job_01.id}" | ||
| tasks: | ||
| - task_key: "task" | ||
| spark_python_task: | ||
| python_file: ./test.py | ||
| new_cluster: | ||
| spark_version: 15.4.x-scala2.12 | ||
| node_type_id: i3.xlarge | ||
| num_workers: 0 | ||
| job_03: | ||
| name: "job-03" | ||
| description: "depends on ${resources.jobs.job_02.id}" | ||
| tasks: | ||
| - task_key: "task" | ||
| spark_python_task: | ||
| python_file: ./test.py | ||
| new_cluster: | ||
| spark_version: 15.4.x-scala2.12 | ||
| node_type_id: i3.xlarge | ||
| num_workers: 0 | ||
| job_04: | ||
| name: "job-04" | ||
| description: "depends on ${resources.jobs.job_03.id}" | ||
| tasks: | ||
| - task_key: "task" | ||
| spark_python_task: | ||
| python_file: ./test.py | ||
| new_cluster: | ||
| spark_version: 15.4.x-scala2.12 | ||
| node_type_id: i3.xlarge | ||
| num_workers: 0 | ||
| job_05: | ||
| name: "job-05" | ||
| description: "depends on ${resources.jobs.job_04.id}" | ||
| tasks: | ||
| - task_key: "task" | ||
| spark_python_task: | ||
| python_file: ./test.py | ||
| new_cluster: | ||
| spark_version: 15.4.x-scala2.12 | ||
| node_type_id: i3.xlarge | ||
| num_workers: 0 | ||
| job_06: | ||
| name: "job-06" | ||
| description: "depends on ${resources.jobs.job_05.id}" | ||
| tasks: | ||
| - task_key: "task" | ||
| spark_python_task: | ||
| python_file: ./test.py | ||
| new_cluster: | ||
| spark_version: 15.4.x-scala2.12 | ||
| node_type_id: i3.xlarge | ||
| num_workers: 0 | ||
| job_07: | ||
| name: "job-07" | ||
| description: "depends on ${resources.jobs.job_06.id}" | ||
| tasks: | ||
| - task_key: "task" | ||
| spark_python_task: | ||
| python_file: ./test.py | ||
| new_cluster: | ||
| spark_version: 15.4.x-scala2.12 | ||
| node_type_id: i3.xlarge | ||
| num_workers: 0 | ||
| job_08: | ||
| name: "job-08" | ||
| description: "depends on ${resources.jobs.job_07.id}" | ||
| tasks: | ||
| - task_key: "task" | ||
| spark_python_task: | ||
| python_file: ./test.py | ||
| new_cluster: | ||
| spark_version: 15.4.x-scala2.12 | ||
| node_type_id: i3.xlarge | ||
| num_workers: 0 | ||
| job_09: | ||
| name: "job-09" | ||
| description: "depends on ${resources.jobs.job_08.id}" | ||
| tasks: | ||
| - task_key: "task" | ||
| spark_python_task: | ||
| python_file: ./test.py | ||
| new_cluster: | ||
| spark_version: 15.4.x-scala2.12 | ||
| node_type_id: i3.xlarge | ||
| num_workers: 0 | ||
| job_10: | ||
| name: "job-10" | ||
| description: "depends on ${resources.jobs.job_09.id}" | ||
| tasks: | ||
| - task_key: "task" | ||
| spark_python_task: | ||
| python_file: ./test.py | ||
| new_cluster: | ||
| spark_version: 15.4.x-scala2.12 | ||
| node_type_id: i3.xlarge | ||
| num_workers: 0 |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I said we should not have this difference I meant it should not be printed in the first place, not that we should hide it :)