Migrate apps commands to new spinner API and add lint rule (#4377)

## Changes

Converts `cmdio.Spinner()` calls to `cmdio.NewSpinner()` in cmd/apps/
directory, following the refactoring pattern from commit 887c3eb.
These deprecated calls were introduced in PR #4369 and PR #4293.

The new API from PR #4351 provides synchronous `Close()` that blocks
until the spinner fully terminates, preventing races with log output.

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: pietern

cmd/apps/bundle_helpers.go

@@ -148,8 +148,14 @@ func shouldWaitForCompletion(cmd *cobra.Command) bool {
 	return !skipWait
 }
 
+// spinnerInterface matches the interface provided by cmdio.NewSpinner.
+type spinnerInterface interface {
+	Update(msg string)
+	Close()
+}
+
 // createAppProgressCallback creates a progress callback for app operations.
-func createAppProgressCallback(spinner chan<- string) func(*apps.App) {
+func createAppProgressCallback(spinner spinnerInterface) func(*apps.App) {
 	return func(i *apps.App) {
 		if i.ComputeStatus == nil {
 			return
@@ -158,7 +164,7 @@ func createAppProgressCallback(spinner chan<- string) func(*apps.App) {
 		if statusMessage == "" {
 			statusMessage = fmt.Sprintf("current status: %s", i.ComputeStatus.State)
 		}
-		spinner <- statusMessage
+		spinner.Update(statusMessage)
 	}
 }
 

cmd/apps/import.go

@@ -94,21 +94,21 @@ Examples:
 			// If no app name provided, list apps and let user select
 			if name == "" {
 				// List all apps
-				spinner := cmdio.Spinner(ctx)
-				spinner <- "Loading available apps..."
+				spinner := cmdio.NewSpinner(ctx)
+				spinner.Update("Loading available apps...")
 				allApps := w.Apps.List(ctx, apps.ListAppsRequest{})
 
 				// Collect all apps
 				var appList []apps.App
 				for allApps.HasNext(ctx) {
 					app, err := allApps.Next(ctx)
 					if err != nil {
-						close(spinner)
+						spinner.Close()
 						return fmt.Errorf("failed to iterate apps: %w", err)
 					}
 					appList = append(appList, app)
 				}
-				close(spinner)
+				spinner.Close()
 
 				if len(appList) == 0 {
 					return errors.New("no apps found in workspace")

cmd/apps/start_bundle.go

@@ -45,9 +45,9 @@ func BundleStartOverrideWithWrapper(wrapError ErrorWrapper) func(*cobra.Command,
 
 						var appInfo *apps.App
 						if shouldWaitForCompletion(cmd) {
-							spinner := cmdio.Spinner(ctx)
+							spinner := cmdio.NewSpinner(ctx)
 							appInfo, err = wait.OnProgress(createAppProgressCallback(spinner)).GetWithTimeout(getWaitTimeout(cmd))
-							close(spinner)
+							spinner.Close()
 							if err != nil {
 								return wrapError(cmd, appName, err)
 							}

cmd/apps/stop_bundle.go

@@ -45,9 +45,9 @@ func BundleStopOverrideWithWrapper(wrapError ErrorWrapper) func(*cobra.Command,
 
 						var appInfo *apps.App
 						if shouldWaitForCompletion(cmd) {
-							spinner := cmdio.Spinner(ctx)
+							spinner := cmdio.NewSpinner(ctx)
 							appInfo, err = wait.OnProgress(createAppProgressCallback(spinner)).GetWithTimeout(getWaitTimeout(cmd))
-							close(spinner)
+							spinner.Close()
 							if err != nil {
 								return wrapError(cmd, appName, err)
 							}

libs/gorules/rule_cmdio_spinner.go

@@ -0,0 +1,12 @@
+package gorules
+
+import "github.com/quasilyte/go-ruleguard/dsl"
+
+// NoNewCmdioSpinner forbids new calls to cmdio.Spinner except in cmd/workspace/ and cmd/account/ directories.
+// This rule ensures that spinner usage is limited to auto-generated workspace and account commands.
+func NoNewCmdioSpinner(m dsl.Matcher) {
+	m.Match(`cmdio.Spinner($*_)`).
+		Where(!m.File().PkgPath.Matches(`.*/cmd/workspace/.*`) &&
+			!m.File().PkgPath.Matches(`.*/cmd/account/.*`)).
+		Report(`cmdio.Spinner is deprecated, no new call sites allowed. Use cmdio.NewSpinner() instead`)
+}