Skip to content

hotfix: avoid re-scanning known valid FKs #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parkan merged 1 commit into from
Dec 5, 2025
Merged

hotfix: avoid re-scanning known valid FKs #601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion model/migrate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,12 +160,14 @@ func migrateFKConstraints(db *gorm.DB) error {
// Drop and recreate with SET NULL
if dialect == "postgres" {
// Postgres DDL is transactional - wrap DROP+ADD so failure rolls back both
// Use NOT VALID to skip row validation - existing rows were valid under CASCADE,
// so they're still valid under SET NULL.
err = db.Transaction(func(tx *gorm.DB) error {
if err := tx.Exec(`ALTER TABLE ` + fk.table + ` DROP CONSTRAINT ` + fk.constraint).Error; err != nil {
return err
}
return tx.Exec(`ALTER TABLE ` + fk.table + ` ADD CONSTRAINT ` + fk.constraint +
` FOREIGN KEY (` + fk.column + `) REFERENCES ` + fk.refTable + `(id) ON DELETE SET NULL`).Error
` FOREIGN KEY (` + fk.column + `) REFERENCES ` + fk.refTable + `(id) ON DELETE SET NULL NOT VALID`).Error
})
if err != nil {
return errors.Wrapf(err, "failed to migrate constraint %s", fk.constraint)
Expand Down