[PLUGIN-675] add hadoop compatible filesystem changes to sftp-put plugin#35
Open
jster1357 wants to merge 1 commit intodata-integrations:developfrom
Open
[PLUGIN-675] add hadoop compatible filesystem changes to sftp-put plugin#35jster1357 wants to merge 1 commit intodata-integrations:developfrom
jster1357 wants to merge 1 commit intodata-integrations:developfrom
Conversation
cleaned up some formatting in the docs
Contributor
There was a problem hiding this comment.
code changes look good,
one suggestion: we can also add a config in the plugin to add file system props as present in SFTP Copy plugin.
ref: https://github.com/data-integrations/sftp-actions/blob/becf6c3044df199598b5b355e47a7de836409b00/src/main/java/io/cdap/plugin/SFTPCopyAction.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://cdap.atlassian.net/browse/PLUGIN-675
Add hadoop compatible changes to sftp-put plugin
cleaned up some formatting in the docs