Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
chtyim
left a comment
chtyim
left a comment
There was a problem hiding this comment.
I only reviewed the first half of the PR. Please fix all the files following the general principles as described in the comments.
pom.xml
Outdated
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| <cdap.version>6.2.0</cdap.version> | ||
| <hydrator.version>2.4.0</hydrator.version> | ||
| <cdap.version>6.1.2</cdap.version> |
There was a problem hiding this comment.
Please don't change dependency version on develop branch
pom.xml
Outdated
| <docs.dir>docs</docs.dir> | ||
|
|
||
| <!-- This is the version range for the app.parents that this plugin is valid for. Usually this will correspond with | ||
| <!-- This is the version range for the app.parents that this plugin is valid for. Usally this will correspond with |
| <dependency> | ||
| <groupId>software.sham</groupId> | ||
| <artifactId>sham-ssh</artifactId> | ||
| <version>0.1.0</version> |
There was a problem hiding this comment.
Add a <scope>test</scope> for test only dependency
pom.xml
Outdated
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
|
|
There was a problem hiding this comment.
extra lines removed throughout codebase
|
|
||
| @Name("compressionFlag") | ||
| @Description("Setting Compression Flag") | ||
| public String compressFlag; |
| @Description("Setting Directory Flag") | ||
| public String dirFlag; | ||
|
|
||
|
|
There was a problem hiding this comment.
Extra Line Removed throughout code
| } | ||
|
|
||
| public byte[] getPrivateKey() { | ||
| assert privateKey != null; |
|
|
||
| public byte[] getPassphrase(){ | ||
| if (passphrase == null){ | ||
| passphrase = ""; |
There was a problem hiding this comment.
Don't mutate field on get call.
return passphrase == null ? new byte[0] : passphrase.getBytes(StandardCharsets.UTF_8);
| if (compressFlag.equals("compression-off")){ | ||
| return compressFlag = ""; | ||
| } | ||
| return compressFlag="-C"; |
Changed formatting
3 participants
Added PrivateKey SSH functionality and new SCP Remote to Remote Action